Return error information on descriptor parse error #16123

pull Empact wants to merge 2 commits into bitcoin:master from Empact:descriptor-parse-error changing 6 files +113 −51

Empact commented at 1:14 am on May 30, 2019: member

This makes descriptors more forgiving by making them more communicative when they fail. These are user input and I expect informative error handling is likely to be appreciated.
Return an error when Parse fails on a descriptor 89d6f052ce
Return an error when ParsePubkey fails on a descriptor 7823b4e1c9
fanquake added the label RPC/REST/ZMQ on May 30, 2019
fanquake added the label Wallet on May 30, 2019
DrahtBot commented at 4:19 am on May 30, 2019: member
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:
- #15986 (Add unmodified-descriptor-with-checksum to getdescriptorinfo by sipa)
- #15590 (Descriptor: add GetAddressType() and IsSegWit() by Sjors)
- #15427 (Add support for descriptors to utxoupdatepsbt by sipa)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
Empact commented at 5:21 am on May 30, 2019: member

Closing for now, in deference to the conflicting PRs
Empact closed this on May 30, 2019
DrahtBot locked this on Dec 16, 2021