define variables about scriptsig size of coinbase tx #16167

1. 
   LongShao007 commented at 3:00 am on June 8, 2019: contributor

   define variables instead of numbers about scriptsig size of coinbase tx

   /** The maximum allowed size for scriptSig in vin of coinbase transaction, in bytes */ static const unsigned int MAX_COINBASE_TX_VIN_SCRIPTSIG_SIZE = 100;

   /** The minimum allowed size for scriptSig in vin of coinbase transaction, in bytes */ static const unsigned int MIN_COINBASE_TX_VIN_SCRIPTSIG_SIZE = 2;

2. define variables about scriptsig size of coinbase tx d9712b1481
3. DrahtBot added the label Mining on Jun 8, 2019
4. 
   DrahtBot commented at 3:58 am on June 8, 2019: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #15921 (Tidy up ValidationState interface by jnewbery)
   • #14633 (Fix height serialization inside script of coinbase input by kostyantyn)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

5. fanquake removed the label Mining on Jun 8, 2019
6. fanquake added the label Consensus on Jun 8, 2019
7. fanquake added the label Refactoring on Jun 8, 2019
8. DrahtBot added the label Needs rebase on Jun 8, 2019
9. DrahtBot removed the label Needs rebase on Jun 8, 2019
10. 
    Empact commented at 1:51 am on June 10, 2019: member

    Design NACK this doesn’t read as a simplification to me, e.g. see the rule of three, which is a good guiding principle.
11. 
    MarcoFalke commented at 6:20 am on June 10, 2019: member

    Thank you for your contribution. While this stylistic change makes sense on its own, it comes at a cost and risk for the project as a whole. The weak motivation for the change does not justify the burden that it places on the project. A burden could be any of the following:

    • Time spent on review
    • Accidental introduction of bugs
    • (Silent) merge conflicts, either in the branch or a backport branch. Those conflicts demand further developer and reviewer time or introduce bugs.

    For more information about refactoring changes and stylistic cleanup, see

    • https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#refactoring
    • https://github.com/bitcoin/bitcoin/blob/master/.github/PULL_REQUEST_TEMPLATE.md
    • #15465

    Generally, if the style is not mentioned nor enforced by the developer notes, we leave it up to the original author to pick whatever fits them best personally and then leave it that way until the line is touched for other reasons.

    Let me know if you have any questions.

12. MarcoFalke closed this on Jun 10, 2019

    ---

13. MarcoFalke locked this on Dec 16, 2021

Contributors
LongShao007 DrahtBot Empact MarcoFalke

Labels
Refactoring Consensus