scripted-diff: gitian: Use REFERENCE_DATETIME directly. #16184

pull dongcarl wants to merge 1 commits into bitcoin:master from dongcarl:2019-06-fix-tar-mtime changing 3 files +8 −8
  1. dongcarl commented at 7:15 pm on June 10, 2019: member

    Fixes regression introduced by #16141.

    0-BEGIN VERIFY SCRIPT-
1sed -i 's#\$REFERENCE_DATE\\\\\\ \$REFERENCE_TIME#\$REFERENCE_DATETIME#g' contrib/gitian-descriptors/*
2-END VERIFY SCRIPT-

    Note that this could have been fixed by escaping properly, but using REFERENCE_DATETIME directly is simpler.

    Future note: REFERENCE_{DATE{,DATETIME},TIME} is a bit ridiculous. At the very least gitian should use epoch, as it is the most parse-able, and preferably set SOURCE_DATE_EPOCH.

  2. scripted-diff: gitian: Use REFERENCE_DATETIME directly. 
    Fixes regression introduced by #16141

-BEGIN VERIFY SCRIPT-
sed -i 's#\$REFERENCE_DATE\\\\\\ \$REFERENCE_TIME#\$REFERENCE_DATETIME#g' contrib/gitian-descriptors/*
-END VERIFY SCRIPT-
    993aa414d3
  3. dongcarl requested review from fanquake on Jun 10, 2019
  4. dongcarl added the label Build system on Jun 10, 2019
  5. dongcarl added the label Needs gitian build on Jun 10, 2019
  6. MarcoFalke commented at 7:44 pm on June 10, 2019: member
    Can you explain how the regression was introduced?
  7. MarcoFalke commented at 7:44 pm on June 10, 2019: member
    Concept ACK
  8. fanquake commented at 7:48 pm on June 10, 2019: member

    Concept ACK. Thanks. @MarcoFalke It was my poor copy-paste, followed by some over-the-shoulder review.

    Also a little related discussion in the #bitcoin-builds IRC channel.

    edit: closing obviously accidental.

  9. fanquake closed this on Jun 10, 2019
  10. fanquake reopened this on Jun 10, 2019
  11. MarcoFalke commented at 7:52 pm on June 10, 2019: member
    Oh, let me rephrase: Why did REFERENCE_TIME && REFERENCE_DATE work previously, but does no longer?
  12. dongcarl commented at 8:07 pm on June 10, 2019: member

    Oh, let me rephrase: Why did REFERENCE_TIME && REFERENCE_DATE work previously, but does no longer? @MarcoFalke https://gist.github.com/dongcarl/c1032fd0236efd62ebc369931c339577

  13. MarcoFalke commented at 8:28 pm on June 10, 2019: member
    Ah, so the issue could be fixed by escaping properly, but you decided to use _DATETIME directly. Sounds fair. Maybe mention that in the OP?
  14. dongcarl commented at 8:42 pm on June 10, 2019: member

    Ah, so the issue could be fixed by escaping properly, but you decided to use _DATETIME directly. Sounds fair. Maybe mention that in the OP?

    Done.

  15. sidhujag commented at 9:06 pm on June 10, 2019: none

    Oh, let me rephrase: Why did REFERENCE_TIME && REFERENCE_DATE work previously, but does no longer?

    I don’t think it was actually being used, it was in a variable and then copied and pasted into the sed by #16141 which broke the build, but should have been escaped

  16. dongcarl commented at 9:34 pm on June 10, 2019: member

    I don’t think it was actually being used, it was in a variable and then copied and pasted into the sed by #16141 which broke the build, but should have been escaped @sidhujag It was being used pre-16141, see: https://www.gnu.org/software/tar/manual/html_node/using-tar-options.html

  17. dongcarl commented at 3:38 pm on June 11, 2019: member 
     0-----BEGIN PGP SIGNED MESSAGE-----
 1Hash: SHA256
 2
 3ab4be93795002308de86cd02a699dd82e53bf4794b11095e651a57e7839d927a  bitcoin-0.18.99-aarch64-linux-gnu-debug.tar.gz
 4b9f3879221d42e6eb836a9de8641aee11359a7bf361020d668f3c5d511f37992  bitcoin-0.18.99-aarch64-linux-gnu.tar.gz
 5e627d30341d80eed6b4d7b74ff1b377e6cdccbe7c39173a0b21fc7bee89ac2f9  bitcoin-0.18.99-arm-linux-gnueabihf-debug.tar.gz
 6c9c0c1c798244770a0212dbd1dbfe53061f34539264933284ee027132e98d600  bitcoin-0.18.99-arm-linux-gnueabihf.tar.gz
 7abf7597ffe132a37f837bc5a239f0d7b2d712a9a85f5a752a5cace2181648338  bitcoin-0.18.99-i686-pc-linux-gnu-debug.tar.gz
 876bedf0ad53e5e699f8bcc6ae00ccde20a927809a10d67682ddf61bb196fcf59  bitcoin-0.18.99-i686-pc-linux-gnu.tar.gz
 93a1d541061568bee5282f918ef21e6ede14c9d8e4676110fa82bfda6608da729  bitcoin-0.18.99-riscv64-linux-gnu-debug.tar.gz
1087e2fd3e11dbe5b9dfecb4a0ddb7e966af561be3f035360af2a8aefec010b746  bitcoin-0.18.99-riscv64-linux-gnu.tar.gz
114372290bfefa8b65904ba0a2df6efc3ad26f476da7f1c5367f7efee2592ea33d  bitcoin-0.18.99-x86_64-linux-gnu-debug.tar.gz
12276f7039c7f0e8038373cf2a8ab9a52d237f076cfb243921f3d3b99ae870d48c  bitcoin-0.18.99-x86_64-linux-gnu.tar.gz
13a09c58d9de205de9cb5f56ee7d02c524e275ed6d7e6aaecfb47c3718ac15295e  src/bitcoin-0.18.99.tar.gz
14f6e72f3efcd2b97410f8fb9428c25e1fcdbfcae83dedb73a45a3e8ce0e087807  bitcoin-core-linux-0.19-res.yml
15-----BEGIN PGP SIGNATURE-----
16
17iQIzBAEBCAAdFiEECc3SW1JEo3Z49u6oDMUhUxl5kaUFAlz/ysgACgkQDMUhUxl5
18kaVLhw/+Lssvjn2oDFR4hQeKfdMduIeytGf+LgPkqykxFXDcA2ujIoDf3gdTpBmz
19SNJbgwh+ukigaaEHJ1FVfJUXnyQrgkhZJzF9Yvcx5BXMh2BjA/h33W6yEf2QJG7/
20vWyQSZpRem2O8ynbZ6sxyeoUL3IpiMG7wdsJ53V5Z8pGN/ZVN3e93VOjJYLUwpuO
21WPyrnbRwKAxRvuNdbQG8vks99U0JXXK8tD4+6fwfh4Po8B+BDyhMbTcClnsXyfVY
22d7SEtAaARqKo/dmueWpBnx7BqmyAniYqVnAjbwh2u2S1ZnbOny0KwJM/61ro4p83
2323Ci2VL7/QE2ew4LVFTs9OZezHhDe9cVP0xML/0BdXriknZYmdPXcLVO9NyMeWQJ
24vCjjVu3hMefqWeCF6qsPrZ6ZyE8buoVkUAppxRvHrcemLorHxREFbPo85diHyd7c
25w7KnjVZ4LjcsVGahWHeyk6ufOwtv/bQ828x9x8WMPZ/Jcn92hNafjgHWoYJAxXi5
26wzKLFDiZO3qqlAKOzF74ALf3jGWmvKEMUgNkdMuVPS9bNPvVeoOYXWDIZ3XGc++o
27mbwPWcuDhAW1ioVE5UMLzZWVYbC+06Ec6FEEux2fpdPv0atLefGyc+YLJ5E/zQUC
287KgG52HCwg2hDKSqZscbG2pbKoDNLI4R2sh91CZfKZeprO5xjDQ=
29=ebkx
30-----END PGP SIGNATURE-----
  18. DrahtBot commented at 4:08 pm on June 11, 2019: member

    Gitian builds for commit 8a503a6c6dd419921373f45d7aa6f1787c9b8884 (master):

    Gitian builds for commit c80f31d50042212dc773aae2a64334038c2067d4 (master and this pull):

  19. DrahtBot removed the label Needs gitian build on Jun 11, 2019
  20. MarcoFalke merged this on Jun 11, 2019
  21. MarcoFalke closed this on Jun 11, 2019
  22. MarcoFalke referenced this in commit 473c6b7c5a on Jun 11, 2019
  23. laanwj commented at 4:35 am on June 12, 2019: member
    Thanks! POsthumous utACK 993aa414d3c54f760c8ae4eb39cb49363acc7f33
  24. theuni commented at 6:39 pm on June 13, 2019: member
    Grr, sorry for missing this in review. Post-merge ACK 993aa414d3c54f760c8ae4eb39cb49363acc7f33.
  25. deadalnix referenced this in commit 10416b0810 on Oct 27, 2020
  26. random-zebra referenced this in commit 3614de632e on Jul 19, 2021
  27. UdjinM6 referenced this in commit c57c89e072 on Oct 23, 2021
  28. UdjinM6 referenced this in commit 6dd986c111 on Dec 4, 2021
  29. UdjinM6 referenced this in commit 632c759352 on Dec 5, 2021
  30. DrahtBot locked this on Dec 16, 2021


dongcarl MarcoFalke fanquake sidhujag DrahtBot laanwj theuni


fanquake

Labels
Build system

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 18:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me