rpc: add 2nd arg to signrawtransactionwithkey examples #16210

pull dooglus wants to merge 1 commits into bitcoin:master from dooglus:patch-7 changing 1 files +2 −2
  1. dooglus commented at 2:37 AM on June 14, 2019: contributor

    The RPC examples for signrawtransactionwithkey are missing the 2nd parameter.

    Before this change the help text showed:

    Examples:
    > bitcoin-cli signrawtransactionwithkey "myhex"
    > curl --user myusername --data-binary '{"jsonrpc": "1.0", "id":"curltest", "method": "signrawtransactionwithkey", "params": ["myhex"] }' -H 'content-type: text/plain;' http://127.0.0.1:8332/

    With the change, it shows:

    Examples:
    > bitcoin-cli signrawtransactionwithkey "myhex" "[\"key1\",\"key2\"]"
    > curl --user myusername --data-binary '{"jsonrpc": "1.0", "id":"curltest", "method": "signrawtransactionwithkey", "params": ["myhex", "[\"key1\",\"key2\"]"] }' -H 'content-type: text/plain;' http://127.0.0.1:8332/
  2. Add example 2nd arg to signrawtransactionwithkey
    The RPC examples for signrawtransactionwithkey are missing the 2nd parameter.
    71fd628ada
  3. fanquake added the label RPC/REST/ZMQ on Jun 14, 2019
  4. promag commented at 6:48 AM on June 14, 2019: member

    ACK, should be backport I guess.

  5. fanquake added the label Needs backport on Jun 14, 2019
  6. fanquake renamed this:
    Add 2nd arg to signrawtransactionwithkey examples
    rpc: add 2nd arg to signrawtransactionwithkey examples
    on Jun 14, 2019
  7. dooglus commented at 3:49 PM on June 14, 2019: contributor

    Do I need to do anything more or can I leave this with you guys? I don't know the correct dance steps to get things merged.

  8. promag commented at 3:59 PM on June 14, 2019: member

    You are good.

  9. Empact commented at 4:13 PM on June 17, 2019: member

    Concept ACK

    Maybe call example keys: "myprivkeyX" to be slightly more explicit?

  10. MarcoFalke referenced this in commit d24d0ec056 on Jun 17, 2019
  11. MarcoFalke removed the label Needs backport on Jun 17, 2019
  12. MarcoFalke merged this on Jun 17, 2019
  13. MarcoFalke closed this on Jun 17, 2019

  14. MarcoFalke referenced this in commit 91958d66cb on Jun 17, 2019
  15. dooglus deleted the branch on Jun 18, 2019
  16. HashUnlimited referenced this in commit 782129cb66 on Aug 23, 2019
  17. Bushstar referenced this in commit 79dffb134c on Aug 24, 2019
  18. vijaydasmp referenced this in commit 6e2ba65a12 on Dec 7, 2021
  19. vijaydasmp referenced this in commit ff81ab1ac9 on Dec 11, 2021
  20. vijaydasmp referenced this in commit d561cbc4c2 on Dec 13, 2021
  21. vijaydasmp referenced this in commit af1d45e59e on Dec 14, 2021
  22. DrahtBot locked this on Dec 16, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me