gui: Refactor wallet controller activities #16215

1. 
   promag commented at 3:26 pm on June 14, 2019: member

   Based on #15450.

   This is similar to #15478 but with a better implementation. Both wallet loading and wallet creation are now asynchronous. The implementation also avoids inner event loops. It should be safe to quit the application or run stop RPC while the dialogs are visible.

2. Optionally allow AskPassphraseDialog to output the passphrase db4edc51da
3. Move wallet creation out of the createwallet rpc into its own function 839bc4dcba
4. Expose wallet creation to the GUI via WalletController 71fe23b5a8
5. Add CreateWalletDialog to create wallets from the GUI b1205bfa4c
6. Add Create Wallet menu action 2ae68a3a33
7. refactor: Add missing include cstdint 9f55bd630a
8. gui: Refactor WalletController activities 3e69f0c9e3
9. 
   promag commented at 3:27 pm on June 14, 2019: member

   Only review last 2 commits.
10. fanquake added the label GUI on Jun 14, 2019
11. 
    DrahtBot commented at 6:42 pm on June 14, 2019: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #16106 (gui: Sort wallets in open wallet menu by promag)
    • #15937 (WIP: Add loadwallet and createwallet load_on_startup options by ryanofsky)
    • #15450 ([GUI] Create wallet menu option by achow101)
    • #15202 (gui: Add Close All Wallets action by promag)
    • #13756 (wallet: “avoid_reuse” wallet flag for improved privacy by kallewoof)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

12. 
    DrahtBot commented at 11:59 pm on June 18, 2019: member
13. DrahtBot added the label Needs rebase on Jun 18, 2019
14. 
    achow101 commented at 1:14 am on June 21, 2019: member

    @promag I think you should just have this PR refactor OpenWalletActivity from current master and then I will pull in the rest of the changes into #15450
15. 
    fanquake commented at 5:39 am on June 24, 2019: member

    @promag Given that @achow101 has pulled these changes into #15450, did you want to close this?
16. 
    promag commented at 1:24 pm on June 24, 2019: member

    @fanquake yap.
17. promag closed this on Jun 24, 2019

    ---

18. promag deleted the branch on Jun 24, 2019
19. fanquake removed the label Needs rebase on Jun 24, 2019
20. MarcoFalke locked this on Dec 16, 2021

Contributors
promag DrahtBot achow101 fanquake

Labels
GUI