build: remove -Wall from rapidcheck build flags #16271

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:rapidcheck_no_wall changing 1 files +4 −0
  1. fanquake commented at 2:50 PM on June 23, 2019: member

    Fixes #16062.

    Remove -Wall from the rapidcheck build flags pre compilation.

    Discussed briefly with theuni.

  2. build: dont compile rapidcheck with -Wall 63d0a079e0
  3. fanquake added the label Build system on Jun 23, 2019
  4. fanquake added the label Needs gitian build on Jun 23, 2019
  5. fanquake requested review from theuni on Jun 23, 2019
  6. fanquake requested review from Christewart on Jun 23, 2019
  7. DrahtBot removed the label Needs gitian build on Jun 25, 2019
  8. MarcoFalke added the label Needs gitian build on Jun 28, 2019
  9. DrahtBot commented at 10:58 AM on June 29, 2019: member

    <!--a722867cd34abeea1fadc8d60700f111-->

    Gitian builds for commit 7400135b7918df9c34206bead744c496e07b0e78 (master):

    Gitian builds for commit d46818c69f524a424223c19e2ef4277bce0b0a6f (master and this pull):

  10. DrahtBot removed the label Needs gitian build on Jun 29, 2019
  11. MarcoFalke deleted a comment on Jun 29, 2019
  12. MarcoFalke commented at 4:10 PM on June 30, 2019: member

    ACK 63d0a079e04dad42c6f63793505a0af59d085a7f (checked that RAPIDCHECK=1 make rapidcheck fails without this)

    <details><summary>Show signature and timestamp</summary>

    Signature:

    -----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

ACK 63d0a079e04dad42c6f63793505a0af59d085a7f (checked that `RAPIDCHECK=1 make rapidcheck` fails without this)
-----BEGIN PGP SIGNATURE-----

iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
pUjzOgwAlq9Aew8dVTwMrjxF61Xfc2a995xVXoRWsyUoRCR5RoFLQXpZxdnZhpdV
9cDiqbHP/Gjh53UXaaZeLP1ZT+SBaxBebrrrCo5ovM7c84yXP4q8pcguRfMdTQdf
M73cnvujhkZQwZiCOXiMyRC73EUOLyftMwmPYzNIuWJ9kXLj62gUyhwvJoKquKTL
IkoPIo0swClTbHmV6azTCbwh80blF2K2VgRLYlVieR7uRW0bAHUD0P/FAmJ5BMAO
+e4Osw0N88j5vLBkuUFETQI2RNdSXljoJuttyC0am2O6OCW9gF7DpRyIeapDr6OB
AZZYJZxjMg0nKIjZNS6RFoGd0+GFnEYufmSm2S2Tiqf0c0dhGlQrhcFHibAbJ0vD
5ZtnHMjMhyyDIs0Z/RUCjw2PFnb0f7z10T+JaTyRcc+IK4gjSAPuSAFheINtpup5
KYTnAdYvAfpp1n+GVdiFoWFA1IqJ/3Rw35q9/P8kauz+fda6WywKf3CE8jb8a8aa
2jbkbRvd
=B6tr
-----END PGP SIGNATURE-----

    Timestamp of file with hash 01a0ceffed746fa5e173c92e942062bc5af0fc5feb3ca63f0e3c601522292e4a -

    </details>

  13. pull[bot] referenced this in commit 6e9eda5567 on Jun 30, 2019
  14. MarcoFalke merged this on Jun 30, 2019
  15. MarcoFalke closed this on Jun 30, 2019
  16. fanquake deleted the branch on Jul 1, 2019
  17. fanquake removed review request from theuni on Jul 1, 2019
  18. fanquake removed review request from Christewart on Jul 1, 2019
  19. sidhujag referenced this in commit afcbf8a541 on Jul 3, 2019
  20. deadalnix referenced this in commit d4cf781ada on Feb 27, 2020
  21. ftrader referenced this in commit 7fa1429b8e on May 19, 2020
  22. DrahtBot locked this on Dec 16, 2021
Contributors
fanquakeDrahtBotMarcoFalke
Labels
Build system
Linked (view graph)
#16062 depends: rapidcheck fails to compile with GCC 9.1
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 00:14 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me