refactoring: wallet: Fix GCC 7.4.0 warning #16286

1. 
   hebasto commented at 5:22 PM on June 25, 2019: member

   Having #13756 and #16239 merged cause GCC warning:

   $ gcc --version
   gcc (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0
   ...
   $ make -j 4 > /dev/null 
   wallet/wallet.cpp: In member function ‘CWallet::Balance CWallet::GetBalance(int, bool) const’:
   wallet/wallet.cpp:2269:45: warning: enumeral and non-enumeral type in conditional expression [-Wextra]
        isminefilter reuse_filter = avoid_reuse ? 0 : ISMINE_USED;
                                    ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
   

   Fixed with this PR.

2. Fix GCC 7.4.0 warning

   Warning: enumeral and non-enumeral type in conditional expression.

   d8bd97d5ee
3. 
   hebasto commented at 5:23 PM on June 25, 2019: member

   ping @kallewoof

4. DrahtBot added the label Wallet on Jun 25, 2019
5. MarcoFalke renamed this:
   Fix GCC 7.4.0 warning
   wallet: Fix GCC 7.4.0 warning
   on Jun 25, 2019
6. MarcoFalke added the label Refactoring on Jun 25, 2019
7. MarcoFalke renamed this:
   wallet: Fix GCC 7.4.0 warning
   refactoring: wallet: Fix GCC 7.4.0 warning
   on Jun 25, 2019
8. MarcoFalke added this to the milestone 0.19.0 on Jun 25, 2019
9. 
   practicalswift commented at 7:25 PM on June 25, 2019: contributor

   utACK d8bd97d5ee766a75dec016203bd4d4aafcc24c4f

10. 
    promag commented at 9:46 PM on June 25, 2019: member

    ACK d8bd97d.

11. 
    kallewoof commented at 12:34 AM on June 26, 2019: member

    utACK d8bd97d5ee766a75dec016203bd4d4aafcc24c4f

12. 
    meshcollider commented at 2:46 AM on June 26, 2019: contributor

    Trivial utACK https://github.com/bitcoin/bitcoin/pull/16286/commits/d8bd97d5ee766a75dec016203bd4d4aafcc24c4f

13. fanquake merged this on Jun 26, 2019
14. fanquake closed this on Jun 26, 2019

    ---

15. fanquake referenced this in commit ca80fec973 on Jun 26, 2019
16. hebasto deleted the branch on Jun 26, 2019
17. DrahtBot locked this on Dec 16, 2021

Contributors

hebastopracticalswiftpromagkallewoofmeshcollider

Milestone
0.19.0