util: Explain why the path is cached #16300

1. 
   MarcoFalke commented at 6:15 pm on June 27, 2019: member

   The rationale for caching the datadir is given as

   0    // This can be called during exceptions by LogPrintf(), so we cache the
   1    // value so we don't have to do memory allocations after that.
   

   Since 8c2d695c4a45bdd9378c7970b0fcba6e1efc01f9, the debug log location is actually cached itself in m_file_path.

   So explain that the caching is now only used to guard against disk access on each call. (See also #16255)

2. MarcoFalke added the label Refactoring on Jun 27, 2019
3. MarcoFalke added the label Utils/log/libs on Jun 27, 2019
4. util: Explain why the path is cached fa69c3e6ca
5. MarcoFalke force-pushed on Jun 27, 2019
6. ryanofsky approved
7. 
   ryanofsky commented at 7:07 pm on June 27, 2019: member

   utACK fa69c3e6ca71800376761e264320c363f072dc2f. Good cleanup. Previous comment was confusing, and definitely not helpful if outdated.
8. 
   DrahtBot commented at 8:10 pm on June 27, 2019: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #16273 (refactor: Remove unused includes by practicalswift)
   • #15934 (Separate settings merging from parsing by ryanofsky)
   • #15864 (Fix datadir handling by hebasto)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

9. 
   promag commented at 7:56 am on June 28, 2019: member

   ACK fa69c3e6ca71800376761e264320c363f072dc2f.
10. 
    laanwj commented at 11:40 am on June 28, 2019: member

    Fair enough, I liked the ambitiousness of getting rid of this code, but, this is a clear and non-controversial improvement ACK fa69c3e6ca71800376761e264320c363f072dc2f
11. laanwj merged this on Jun 28, 2019
12. laanwj closed this on Jun 28, 2019

    ---

13. laanwj referenced this in commit 935cd6b1ec on Jun 28, 2019
14. MarcoFalke deleted the branch on Jun 28, 2019
15. deadalnix referenced this in commit 1bbbeffc36 on Apr 20, 2020
16. ftrader referenced this in commit 815e3ad735 on Aug 17, 2020
17. Munkybooty referenced this in commit 64fce323fd on Nov 2, 2021
18. Munkybooty referenced this in commit 9a7cf8a58c on Nov 2, 2021
19. Munkybooty referenced this in commit a4a88e171a on Nov 4, 2021
20. Munkybooty referenced this in commit ab31a99dff on Nov 16, 2021
21. Munkybooty referenced this in commit c2b9f011ce on Nov 18, 2021
22. DrahtBot locked this on Dec 16, 2021

Contributors
MarcoFalke ryanofsky DrahtBot promag laanwj

Labels
Refactoring Utils/log/libs