test: Add missing syncwithvalidationinterfacequeue to wallet_balance test #16302

1. 
   MarcoFalke commented at 12:49 PM on June 28, 2019: member

   A syncwithvalidationinterfacequeue should be sufficient.

   Fixes #16020

2. MarcoFalke added the label Needs backport on Jun 28, 2019
3. MarcoFalke added the label Tests on Jun 28, 2019
4. MarcoFalke added this to the milestone 0.18.1 on Jun 28, 2019
5. MarcoFalke removed this from the milestone 0.18.1 on Jun 28, 2019
6. MarcoFalke added this to the milestone 0.19.0 on Jun 28, 2019
7. MarcoFalke removed the label Needs backport on Jun 28, 2019
8. MarcoFalke removed the label Tests on Jun 28, 2019
9. 
   fanquake commented at 12:52 PM on June 28, 2019: member

   cc @IlyasRidhuan

10. fanquake added the label Tests on Jun 28, 2019
11. test: Add missing sync_all to wallet_balance test fa815255c7
12. MarcoFalke force-pushed on Jun 28, 2019
13. MarcoFalke force-pushed on Jun 28, 2019
14. 
    promag commented at 10:07 PM on June 29, 2019: member

    Still not using sync_all as OP suggests, although I think sync_blocks and syncwithvalidationinterfacequeue is enough. If you keep current commit please update PR.

    Just to be clear about the problem, there's a race between getbalance and CWallet::BlockConnected.

    ACK fa81525. This can be tested by adding sleep in CWallet::BlockConnected just before LOCK(cs_wallet) - master will always fail while this PR will succeed.

15. MarcoFalke renamed this:
    test: Add missing sync_all to wallet_balance test
    test: Add missing syncwithvalidationinterfacequeue to wallet_balance test
    on Jun 29, 2019
16. MarcoFalke referenced this in commit e7f3450b7d on Jun 30, 2019
17. MarcoFalke merged this on Jun 30, 2019
18. MarcoFalke closed this on Jun 30, 2019

    ---

19. MarcoFalke deleted the branch on Jun 30, 2019
20. MarcoFalke referenced this in commit e2d36639ca on Mar 12, 2020
21. sidhujag referenced this in commit b5531960ba on Mar 13, 2020
22. jasonbcox referenced this in commit 7a820a75ec on Jul 16, 2020
23. sidhujag referenced this in commit e8599a1feb on Nov 10, 2020
24. PastaPastaPasta referenced this in commit 39136e6c43 on Jun 27, 2021
25. PastaPastaPasta referenced this in commit d6fadb28bb on Jun 28, 2021
26. PastaPastaPasta referenced this in commit 35bb03740e on Jun 29, 2021
27. PastaPastaPasta referenced this in commit 785e7b99ff on Jul 1, 2021
28. PastaPastaPasta referenced this in commit b8676ddc7d on Jul 1, 2021
29. DrahtBot locked this on Dec 16, 2021

Contributors

MarcoFalkefanquakepromag

Milestone
0.19.0