scripts and tools: Update copyright_header.py script #16314

pull hebasto wants to merge 3 commits into bitcoin:master from hebasto:20190629-copyright-headers changing 2 files +2 −5

hebasto commented at 4:08 PM on June 29, 2019: member
Now the copyright_header.py script handles Objective-C source files *.mm:
```
src/qt/macdockiconhandler.mm
src/qt/macnotificationhandler.mm
src/qt/macos_appnap.mm
```
Also the only occurrence of Bitcoin Core Developers replaced with ubiquitous The Bitcoin Core developers.

EDITED: The reason to remove "Sam Rushing" is (on master):
```
$ git grep "Sam Rushing"
contrib/devtools/copyright_header.py:    "Sam Rushing\n",
```

Include Objective-C source files

The copyright_header.py script will process Objective-C source files 
(*.mm) as other ones.

01fafe55a1

Drop no-longer-relevant copyright holder name 621463d7df
Fix: "Bitcoin Core" -> "The Bitcoin Core" ca11606858
DrahtBot added the label Scripts and tools on Jun 29, 2019
DrahtBot commented at 5:34 PM on June 29, 2019: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #15257 (Scripts and tools: Bump flake8 to 3.7.7 by Empact)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
in contrib/devtools/copyright_header.py:100 in ca11606858
```
  95 |      "University of Illinois at Urbana-Champaign\.\n",
  96 |      "Pieter Wuille\n",
  97 |      "Wladimir J. van der Laan\n",
  98 |      "Jeff Garzik\n",
  99 |      "Jan-Klaas Kollhof\n",
 100 | -    "Sam Rushing\n",
```
promag commented at 9:11 AM on June 30, 2019:

Why is Sam removed?
practicalswift commented at 9:12 AM on June 30, 2019:

$ git grep "Sam Rushing" contrib/devtools/copyright_header.py: "Sam Rushing\n", $
promag commented at 9:20 AM on June 30, 2019:

Ok, maybe mention it in the OP.

hebasto commented at 10:14 AM on June 30, 2019:

@promag

Ok, maybe mention it in the OP.

Done.

practicalswift commented at 9:11 AM on June 30, 2019: contributor

Concept ACK

Is there any reason to list individual copyright holders that also belong to the group "The Bitcoin Core developers"?

If not it would be nice to reduce the number of individual copyright holders and simplify this script.

If @sipa, @laanwj and @JeremyRubin so allows it would be nice to replace the following with "The Bitcoin Core developers":

$ git grep -iE 'Copyright.*(Pieter Wuille|Wladimir J. van der Laan|Jeremy Rubin)' ":(exclude)src/crypto/ctaes/" ":(exclude)src/leveldb/" ":(exclude)src/secp256k1/" ":(exclude)src/univalue/" ":(exclude)contrib/devtools/"
build_msvc/libsecp256k1_config.h: * Copyright (c) 2013, 2014 Pieter Wuille                             *
contrib/seeds/generate-seeds.py:# Copyright (c) 2014-2017 Wladimir J. van der Laan
src/addrman.cpp:// Copyright (c) 2012 Pieter Wuille
src/addrman.h:// Copyright (c) 2012 Pieter Wuille
src/bech32.cpp:// Copyright (c) 2017 Pieter Wuille
src/bech32.h:// Copyright (c) 2017 Pieter Wuille
src/cuckoocache.h:// Copyright (c) 2016 Jeremy Rubin
src/test/bech32_tests.cpp:// Copyright (c) 2017 Pieter Wuille
test/functional/test_framework/descriptors.py:# Copyright (c) 2019 Pieter Wuille
test/functional/test_framework/key.py:# Copyright (c) 2019 Pieter Wuille
test/functional/test_framework/segwit_addr.py:# Copyright (c) 2017 Pieter Wuille

Perhaps build_msvc/libsecp256k1_config.h being be the exception (since it is part of secp256k1). @sipa @laanwj @JeremyRubin - would you allow being listed as "The Bitcoin Core developers" instead of as individuals?

laanwj commented at 2:54 PM on July 1, 2019: member

code review ACK ca11606858a787c133983dcb1e0fea2ac54fc530 @practicalswift i'm fiine with that but also think simplifying that script is a non-issue
practicalswift commented at 8:30 AM on July 2, 2019: contributor

@laanwj Do you know the history behind these individual copyright notices? Is there any reason to list individual copyright holders that also belong to the group "The Bitcoin Core developers"?
MarcoFalke referenced this in commit c84349a148 on Jul 2, 2019
MarcoFalke merged this on Jul 2, 2019
MarcoFalke closed this on Jul 2, 2019
hebasto deleted the branch on Jul 2, 2019
kittywhiskers referenced this in commit 3ee097114e on Jul 11, 2021
kittywhiskers referenced this in commit c6d8667ccf on Jul 11, 2021
PastaPastaPasta referenced this in commit f1f32364f6 on Jul 13, 2021
Fabcien referenced this in commit 9e2e1625de on Jul 20, 2021
DrahtBot locked this on Dec 16, 2021

Contributors

Labels

scripts and tools: Update copyright_header.py script #16314

Conflicts