[RPC] add new utxoupdatepsbt arguments to the CRPCCommand and CPRCCvertParam tables #16326

1. 
   jnewbery commented at 5:44 pm on July 2, 2019: member

   The new descriptors argument was not added to the CRPCCommand and CPRCCvertParam tables, meaning that it couldn’t be used with bitcoin-cli or named arguments.

   Before this PR:

   0> bitcoin-cli utxoupdatepsbt 'cHNidP8BAFMCAAAAAYCdwVRx2X3o4KHx5tAMsN1ddp51MbfWsietjfMbl5HtAAAAAAD/////AQDh9QUAAAAAF6kUW+rtEOi4nk9rpw2F5XZl1dd8ehGHAAAAAAAAAA==' "[{\"desc\":\"sh(wpkh([bd50871a/0h/0h/0h]03895c66337b38699bfafff1084ad35bc347fac4f4e5e5fe5eb7dd81155280db53))\"}]"
   1error code: -3
   2error message:
   3Expected type array, got string
   4> bitcoin-cli --named utxoupdatepsbt psbt='cHNidP8BAFMCAAAAAYCdwVRx2X3o4KHx5tAMsN1ddp51MbfWsietjfMbl5HtAAAAAAD/////AQDh9QUAAAAAF6kUW+rtEOi4nk9rpw2F5XZl1dd8ehGHAAAAAAAAAA==' descriptors="[{\"desc\":\"sh(wpkh([bd50871a/0h/0h/0h]03895c66337b38699bfafff1084ad35bc347fac4f4e5e5fe5eb7dd81155280db53))\"}]"
   5error code: -8
   6error message:
   7Unknown named parameter descriptors
   

   After this PR:

   0bitcoin-cli utxoupdatepsbt 'cHNidP8BAFMCAAAAAYCdwVRx2X3o4KHx5tAMsN1ddp51MbfWsietjfMbl5HtAAAAAAD/////AQDh9QUAAAAAF6kUW+rtEOi4nk9rpw2F5XZl1dd8ehGHAAAAAAAAAA==' "[{\"desc\":\"sh(wpkh([bd50871a/0h/0h/0h]03895c66337b38699bfafff1084ad35bc347fac4f4e5e5fe5eb7dd81155280db53))\"}]"
   1cHNidP8BAFMCAAAAAYCdwVRx2X3o4KHx5tAMsN1ddp51MbfWsietjfMbl5HtAAAAAAD/////AQDh9QUAAAAAF6kUW+rtEOi4nk9rpw2F5XZl1dd8ehGHAAAAAAAAAA==
   2bitcoin-cli --named utxoupdatepsbt psbt='cHNidP8BAFMCAAAAAYCdwVRx2X3o4KHx5tAMsN1ddp51MbfWsietjfMbl5HtAAAAAAD/////AQDh9QUAAAAAF6kUW+rtEOi4nk9rpw2F5XZl1dd8ehGHAAAAAAAAAA==' descriptors="[{\"desc\":\"sh(wpkh([bd50871a/0h/0h/0h]03895c66337b38699bfafff1084ad35bc347fac4f4e5e5fe5eb7dd81155280db53))\"}]"
   3cHNidP8BAFMCAAAAAYCdwVRx2X3o4KHx5tAMsN1ddp51MbfWsietjfMbl5HtAAAAAAD/////AQDh9QUAAAAAF6kUW+rtEOi4nk9rpw2F5XZl1dd8ehGHAAAAAAAAAA==
   

2. 
   jnewbery commented at 5:45 pm on July 2, 2019: member

   Follow-up to #15427. Reported by @ariard here: #15427#pullrequestreview-239730895.
3. 
   sipa commented at 6:17 pm on July 2, 2019: member

   Concept ACK, code looks goods.
4. 
   MarcoFalke commented at 8:33 pm on July 2, 2019: member

   Could make one of the calls in the functional tests use named args?
5. 
   MarcoFalke commented at 8:38 pm on July 2, 2019: member

   Does #15427 need release notes? If so, you may add them in this pull.
6. fanquake added the label RPC/REST/ZMQ on Jul 2, 2019
7. fanquake approved
8. 
   fanquake commented at 3:29 am on July 4, 2019: member

   ACK df699195f4866068b86acf914b0aed8cc8f91e49

   Checked that this fixes bitcoin-cli and named arguments usage. @jnewbery did you want to update the test or add release notes here?

9. [RPC] add new utxoupdatepsbt arguments to the CRPCCommand and CPRCConvertParam tables

   The new `descriptors` argument needs to be added to the Command and
   ConvertParams tables to by usable as a named argument and by
   bitcoin-cli.
   
   Also update the test to use named arguments to test this.

   3b11420b3c
10. jnewbery force-pushed on Jul 4, 2019
11. 
    jnewbery commented at 12:06 pm on July 4, 2019: member

    Added named arguments to the test and release notes.
12. in doc/release-notes-15427.md:4 in a52ec281b0 outdated

    0@@ -0,0 +1,9 @@
    1+Updated RPCs
    2+------------
    3+
    4+The `utxoupdatepsbt` RPB method has been updated to take a `descriptors`
    

    ---

    ---

    

    fanquake commented at 2:05 am on July 5, 2019:

    nit: RPC

    ---

    

    jnewbery commented at 9:47 am on July 5, 2019:

    thanks. Fixed
13. fanquake approved
14. 
    fanquake commented at 2:20 am on July 5, 2019: member

    ACK a52ec281b0ceed278c8b65524dc1ab601281ce27

    Thanks for updating the test and adding the release notes for #15427.

15. [docs] Add release notes for PR 15427 91cc18f602
16. jnewbery force-pushed on Jul 5, 2019
17. fanquake approved
18. 
    fanquake commented at 11:29 am on July 5, 2019: member

    re-ACK 91cc18f602fe2ff7fe47335a8e1e7734895a19d9
19. 
    promag commented at 2:52 pm on July 6, 2019: member

    ACK 91cc18f.
20. fanquake merged this on Jul 7, 2019
21. fanquake closed this on Jul 7, 2019

    ---

22. fanquake referenced this in commit 584168c7f9 on Jul 7, 2019
23. sidhujag referenced this in commit 665ca2683a on Jul 7, 2019
24. jnewbery deleted the branch on Jul 7, 2019
25. deadalnix referenced this in commit c7bc25d97f on Jun 23, 2020
26. DrahtBot locked this on Dec 16, 2021

Contributors
jnewbery sipa MarcoFalke fanquake promag

Labels
RPC/REST/ZMQ