build: use #if HAVE_SYSTEM instead of defined(HAVE_SYSTEM) #16344

1. 
   Sjors commented at 4:39 pm on July 5, 2019: member

   It seems that AC_DEFINE([HAVE_SYSTEM], [HAVE_STD__SYSTEM || HAVE_WSYSTEM] causes HAVE_SYSTEM to always be defined, so we need to use #if HAVE_SYSTEM instead of #if defined(HAVE_SYSTEM).

   Followup for #15457, can be tested with #12557.

2. [build]: use #if HAVE_SYSTEM instead of defined(HAVE_SYSTEM) 976b034b13
3. fanquake added the label Build system on Jul 5, 2019
4. 
   qmma70 commented at 0:13 am on July 6, 2019: contributor

   Approach ACK. AC_DEFINE will always define the pre-processor symbol.
5. fanquake requested review from dongcarl on Jul 6, 2019
6. 
   promag commented at 2:57 pm on July 6, 2019: member

   ACK 976b034b13d28877aee641833d5ee28a8cc5d83f.
7. 
   dongcarl commented at 5:08 pm on July 6, 2019: member

   ACK https://github.com/bitcoin/bitcoin/pull/16344/commits/976b034b13d28877aee641833d5ee28a8cc5d83f.

   Perhaps (in another PR/issue) we should make sure that for other preprocessor symbols we mean define(FOOBAR) when we say it. @fanquake does that sound reasonable?

8. fanquake renamed this:
   [build]: use #if HAVE_SYSTEM instead of defined(HAVE_SYSTEM)
   build: use #if HAVE_SYSTEM instead of defined(HAVE_SYSTEM)
   on Jul 7, 2019
9. fanquake approved
10. 
    fanquake commented at 2:36 am on July 7, 2019: member

    ACK 976b034b13d28877aee641833d5ee28a8cc5d83f

    Tested on my macOS system with master (584168c7f9d9e78a3bf82ab85b52feb0ced67f9d) and with #12557.

    Perhaps (in another PR/issue) we should make sure that for other preprocessor symbols we mean define(FOOBAR) when we say it. @fanquake does that sound reasonable? @dongcarl yes that sounds like a good idea.

11. fanquake merged this on Jul 7, 2019
12. fanquake closed this on Jul 7, 2019

    ---

13. fanquake referenced this in commit f373beebbc on Jul 7, 2019
14. Sjors deleted the branch on Jul 7, 2019
15. PastaPastaPasta referenced this in commit 79e5eb8a63 on Oct 22, 2021
16. MarcoFalke locked this on Dec 16, 2021

Contributors
Sjors qmma70 promag dongcarl fanquake

Review Requested
dongcarl

Labels
Build system