It seems that AC_DEFINE([HAVE_SYSTEM], [HAVE_STD__SYSTEM || HAVE_WSYSTEM] causes HAVE_SYSTEM to always be defined, so we need to use #if HAVE_SYSTEM instead of #if defined(HAVE_SYSTEM).
build: use #if HAVE_SYSTEM instead of defined(HAVE_SYSTEM) #16344
pull Sjors wants to merge 1 commits into bitcoin:master from Sjors:2019/07/system-ifdef changing 6 files +9 −9-
Sjors commented at 4:39 PM on July 5, 2019: member
-
[build]: use #if HAVE_SYSTEM instead of defined(HAVE_SYSTEM) 976b034b13
- fanquake added the label Build system on Jul 5, 2019
-
qmma70 commented at 12:13 AM on July 6, 2019: contributor
Approach ACK.
AC_DEFINEwill always define the pre-processor symbol. - fanquake requested review from dongcarl on Jul 6, 2019
-
promag commented at 2:57 PM on July 6, 2019: member
ACK 976b034b13d28877aee641833d5ee28a8cc5d83f.
-
dongcarl commented at 5:08 PM on July 6, 2019: member
ACK https://github.com/bitcoin/bitcoin/pull/16344/commits/976b034b13d28877aee641833d5ee28a8cc5d83f.
Perhaps (in another PR/issue) we should make sure that for other preprocessor symbols we mean
define(FOOBAR)when we say it. @fanquake does that sound reasonable? - fanquake renamed this:
[build]: use #if HAVE_SYSTEM instead of defined(HAVE_SYSTEM)
build: use #if HAVE_SYSTEM instead of defined(HAVE_SYSTEM)
on Jul 7, 2019 - fanquake approved
-
fanquake commented at 2:36 AM on July 7, 2019: member
ACK 976b034b13d28877aee641833d5ee28a8cc5d83f
Tested on my macOS system with master (584168c7f9d9e78a3bf82ab85b52feb0ced67f9d) and with #12557.
Perhaps (in another PR/issue) we should make sure that for other preprocessor symbols we mean define(FOOBAR) when we say it. @fanquake does that sound reasonable? @dongcarl yes that sounds like a good idea.
- fanquake merged this on Jul 7, 2019
- fanquake closed this on Jul 7, 2019
- fanquake referenced this in commit f373beebbc on Jul 7, 2019
- Sjors deleted the branch on Jul 7, 2019
- PastaPastaPasta referenced this in commit 79e5eb8a63 on Oct 22, 2021
- MarcoFalke locked this on Dec 16, 2021
