build: Review of depends tree configure flags #16354

issue dongcarl openend this issue on July 8, 2019
  1. dongcarl commented at 2:56 pm on July 8, 2019: member

    While doing depends builds, I noticed that there are many configure flags that weren’t recognized by our packages. This leads to things like: #16183. This is most likely caused by either overzealous configure flag adding, or updating depends packages without looking at changes to accepted configure flags.

    I propose that we:

    1. Prune configure flags from depends that packages don’t understand.
    2. Add documentation on updating packages (namely that new configure flags should be checked).
    3. (stretch-goal) Find out what --without- and --disable- configure flags we can supply to speed up depends builds.

    CC @fanquake @theuni

  2. dongcarl added the label Build system on Jul 8, 2019
  3. MarcoFalke commented at 4:49 pm on July 8, 2019: member
    Is there a grep line you could use to find all flags that are not understood in a full (fresh) depends build output?
  4. dongcarl commented at 8:35 pm on July 8, 2019: member
    @MarcoFalke I believe you can grep '\bconfigure\b.\+\bunrecognized options\b' on stderr
  5. MarcoFalke added the label good first issue on Jul 8, 2019
  6. laanwj referenced this in commit a54a12046e on Jul 25, 2019
  7. konez2k referenced this in commit 5e9dd64953 on Jul 27, 2019
  8. meshcollider referenced this in commit 3ca514ddb7 on Aug 24, 2019
  9. sidhujag referenced this in commit d89bdedbc5 on Aug 25, 2019
  10. fanquake commented at 9:54 am on September 23, 2019: member

    Here’s a non-extensive list of some of the outstanding unrecognized options::

    macOS

    0make bdb_configured -C depends/
1configure: WARNING: unrecognized options: --disable-dependency-tracking
2configure: WARNING: If you wanted to set the --build type, don't use --host.
3    If a cross compiler is detected then cross compile mode will be used.
4configure: WARNING: unrecognized options: --disable-dependency-tracking

    0PROTOBUF=1 make protobuf_configured -C depends/
1configure: WARNING: Impossible to determine how to use pthreads with shared libraries and -nostdlib

    debian

    0make freetype_configured -C depends/
1configure: WARNING: unrecognized options: --disable-dependency-tracking

     0make libxcb_configured -C depends/
 1configure: WARNING: unrecognized options: --disable-dependency-tracking, --disable-shared, --with-pic
 2configure: WARNING: xmllint not found; unable to validate against schema.
 3configure: WARNING: unrecognized options: --disable-dependency-tracking, --disable-shared, --with-pic
 4-c:2: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses
 5Package xorg-macros was not found in the pkg-config search path.
 6Perhaps you should add the directory containing `xorg-macros.pc'
 7to the PKG_CONFIG_PATH environment variable
 8No package 'xorg-macros' found
 9configure: WARNING: if you wanted to set the --build type, don't use --host.
10    If a cross compiler is detected then cross compile mode will be used
11Package xorg-macros was not found in the pkg-config search path.
12Perhaps you should add the directory containing `xorg-macros.pc'
13to the PKG_CONFIG_PATH environment variable
14No package 'xorg-macros' found
15ar: `u' modifier ignored since `D' is the default (see `U')
16libtool: install: warning: remember to run `libtool --finish /bitcoin/depends/x86_64-pc-linux-gnu/lib'

    0make libXau_configured -C depends/
1configure: WARNING: if you wanted to set the --build type, don't use --host.
2    If a cross compiler is detected then cross compile mode will be used
3Package xorg-macros was not found in the pkg-config search path.
4Perhaps you should add the directory containing `xorg-macros.pc'
5to the PKG_CONFIG_PATH environment variable
6No package 'xorg-macros' found

    0make xproto_configured -C depends/
1Package xorg-macros was not found in the pkg-config search path.
2Perhaps you should add the directory containing `xorg-macros.pc'
3to the PKG_CONFIG_PATH environment variable
4No package 'xorg-macros' found

    0make xcb_proto_configured -C depends/
1configure: WARNING: unrecognized options: --disable-dependency-tracking, --disable-shared, --with-pic
2configure: WARNING: xmllint not found; unable to validate against schema.
3configure: WARNING: unrecognized options: --disable-dependency-tracking, --disable-shared, --with-pic

    0HOST=x86_64-apple-darwin14 make native_cctools_configured
1configure: WARNING: unrecognized options: --disable-dependency-tracking
  11. fanquake referenced this in commit 19eb427dc8 on Sep 24, 2019
  12. fanquake referenced this in commit bcff8e21b1 on Oct 11, 2019
  13. fanquake referenced this in commit fd3b4e422d on Oct 18, 2019
  14. sidhujag referenced this in commit 8fd9ef011a on Oct 21, 2019
  15. fanquake commented at 5:56 pm on December 8, 2019: member

    Current depends configure warnings:

    macOS

    0make bdb_configured -C depends/
1configure: WARNING: If you wanted to set the --build type, don't use --host.
2    If a cross compiler is detected then cross compile mode will be used.

    Debian

    0make xcb_proto_configured -C depends/
1configure: WARNING: unrecognized options: --disable-shared, --with-pic
2configure: WARNING: xmllint not found; unable to validate against schema.

    0make xproto_configured -C depends/
1Package xorg-macros was not found in the pkg-config search path.
2Perhaps you should add the directory containing `xorg-macros.pc'
3to the PKG_CONFIG_PATH environment variable
4No package 'xorg-macros' found

    0make libXau_configured -C depends/
1configure: WARNING: if you wanted to set the --build type, don't use --host.
2    If a cross compiler is detected then cross compile mode will be used
3Package xorg-macros was not found in the pkg-config search path.
4Perhaps you should add the directory containing `xorg-macros.pc'
5to the PKG_CONFIG_PATH environment variable
6No package 'xorg-macros' found
  16. dongcarl commented at 5:03 pm on December 9, 2019: member

    Yeah so all the xorg things want xorg-macros to be there so it can regenerate or something… Not 100% sure if it’s a good idea to include xorg-macros in depends for more visibility into their Makefile generation

    For the --build --host thing, this might be the right clue: https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.69/html_node/Specifying-Target-Triplets.html#Specifying-Target-Triplets

    For historical reasons, whenever you specify –host, be sure to specify –build too

  17. laanwj closed this on Dec 11, 2019
  18. dongcarl reopened this on Dec 11, 2019
  19. dongcarl commented at 5:18 pm on December 11, 2019: member
    GitHub trying to be smart… :roll_eyes:
  20. sidhujag referenced this in commit faad1bc50b on Dec 12, 2019
  21. str4d referenced this in commit 3420f0171e on Oct 5, 2020
  22. sidhujag referenced this in commit dd3fc98fd7 on Nov 10, 2020
  23. fanquake referenced this in commit 4f91544c4d on Mar 10, 2021
  24. fanquake referenced this in commit 735610940c on Mar 31, 2021
  25. fanquake referenced this in commit 9565dafed5 on Apr 3, 2021
  26. fanquake commented at 5:21 am on April 3, 2021: member
    @dongcarl Now that #21403 is merged, what would you like todo here?
  27. sidhujag referenced this in commit 5e54665430 on Apr 3, 2021
  28. dongcarl commented at 8:31 pm on April 5, 2021: member
    Sounds like we can close this :-) Thank you @fanquake for all the work!
  29. dongcarl closed this on Apr 5, 2021
  30. fanquake removed the label good first issue on Apr 6, 2021
  31. PastaPastaPasta referenced this in commit acd870a77c on Jun 27, 2021
  32. PastaPastaPasta referenced this in commit 650dc04a4c on Jun 28, 2021
  33. PastaPastaPasta referenced this in commit 4168b467d5 on Jun 29, 2021
  34. PastaPastaPasta referenced this in commit 76d59a737c on Jul 1, 2021
  35. PastaPastaPasta referenced this in commit 565a0c5748 on Jul 1, 2021
  36. PastaPastaPasta referenced this in commit 8a044ebc0e on Jul 12, 2021
  37. PastaPastaPasta referenced this in commit 7fcb8f53ed on Jul 13, 2021
  38. PastaPastaPasta referenced this in commit 0af66e6574 on Sep 11, 2021
  39. PastaPastaPasta referenced this in commit 1b5d29bb9c on Sep 11, 2021
  40. Munkybooty referenced this in commit 97632ca890 on Nov 9, 2021
  41. Munkybooty referenced this in commit ccd976d600 on Nov 16, 2021
  42. Munkybooty referenced this in commit bf59b2ec92 on Nov 18, 2021
  43. Munkybooty referenced this in commit dcca9d8eb1 on Nov 24, 2021
  44. Munkybooty referenced this in commit 3e40a99573 on Nov 30, 2021
  45. Munkybooty referenced this in commit a9727f8c24 on Dec 15, 2021
  46. Munkybooty referenced this in commit f4ce3738c2 on Dec 17, 2021
  47. Munkybooty referenced this in commit 5e8474fbe5 on Dec 24, 2021
  48. Munkybooty referenced this in commit 94dfa72738 on Jan 19, 2022
  49. Munkybooty referenced this in commit 0ec883f34c on Jan 24, 2022
  50. gades referenced this in commit 67fcfdd003 on Apr 20, 2022
  51. gades referenced this in commit 351f8485f9 on Apr 20, 2022
  52. vijaydasmp referenced this in commit 96139b5657 on Apr 25, 2022
  53. vijaydasmp referenced this in commit 47c9d7962a on May 10, 2022
  54. vijaydasmp referenced this in commit a90064c62e on May 19, 2022
  55. vijaydasmp referenced this in commit a2a06dae2a on May 19, 2022
  56. knst referenced this in commit 547f33608c on Jun 7, 2022
  57. knst referenced this in commit b9893e5025 on Jun 8, 2022
  58. vijaydasmp referenced this in commit 46d94b9665 on Jun 14, 2022
  59. vijaydasmp referenced this in commit 02794a4fa7 on Jun 15, 2022
  60. vijaydasmp referenced this in commit 718e57f7fb on Jun 15, 2022
  61. vijaydasmp referenced this in commit de57bfe0f5 on Jun 15, 2022
  62. vijaydasmp referenced this in commit e73f270198 on Jun 16, 2022
  63. vijaydasmp referenced this in commit d8d22343c9 on Jun 16, 2022
  64. vijaydasmp referenced this in commit 08f1234eb6 on Jun 17, 2022
  65. vijaydasmp referenced this in commit 752e1c4834 on Jun 18, 2022
  66. vijaydasmp referenced this in commit 746ff12632 on Jun 18, 2022
  67. DrahtBot locked this on Aug 18, 2022


dongcarl MarcoFalke fanquake

Labels
Build system

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 12:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me