Remove all bits that have no BIP specification nor can be observed on the active network
Remove unused bits from the service flags enum #16380
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:1907-netRemoveUnusedServiceBits changing 2 files +4 −10-
MarcoFalke commented at 6:18 PM on July 12, 2019: member
-
Remove unused bits from the service flags enum fa0d0ff6e1
- DrahtBot added the label GUI on Jul 12, 2019
-
practicalswift commented at 4:13 PM on July 13, 2019: contributor
utACK fa0d0ff6e1bee60fde63724ae28a51aac5a94d4a
-
LarryRuane commented at 4:00 AM on July 14, 2019: contributor
utACK fa0d0ff6e1bee60fde63724ae28a51aac5a94d4a
-
promag commented at 10:50 PM on July 14, 2019: member
ACK fa0d0ff6e1bee60fde63724ae28a51aac5a94d4a.
-
laanwj commented at 7:10 PM on July 15, 2019: member
ACK fa0d0ff6e1bee60fde63724ae28a51aac5a94d4a
- fanquake merged this on Jul 16, 2019
- fanquake closed this on Jul 16, 2019
- fanquake referenced this in commit 29082e8f40 on Jul 16, 2019
- MarcoFalke deleted the branch on Jul 16, 2019
-
rebroad commented at 3:38 AM on April 10, 2020: contributor
I'm still seeing nodes on the network advertising the THIN service bit, e.g.:-
2020-04-04 18:50:59.012 recv version: /Classic:1.3.4(EB8)/: version 80002, blocks=642087, relay=1, services=0x35 us=x.x.x.x:8333, them=103.76.41.69:57664, peer=42933 2020-04-09 06:28:14.209 recv version: /BUCash:1.1.2(EB16; AD12)/: version 80003, blocks=530361, relay=1, services=0x35 us=x.x.x.x:8333, them=31.172.81.167:43308, peer=364
I am seeing fewer nodes using GETUTXO than are using XTHIN so it would have made more sense to remove that service bit.
- Fabcien referenced this in commit b051c69478 on Jan 15, 2021
- Munkybooty referenced this in commit 3046119342 on Nov 4, 2021
- Munkybooty referenced this in commit 437613ee62 on Nov 6, 2021
- Munkybooty referenced this in commit 73cc03192b on Nov 12, 2021
- Munkybooty referenced this in commit 63c2906eea on Nov 16, 2021
- Munkybooty referenced this in commit a773302be0 on Nov 18, 2021
- Munkybooty referenced this in commit e6272606ba on Nov 19, 2021
- Munkybooty referenced this in commit 8eaa2ae173 on Nov 24, 2021
- Munkybooty referenced this in commit af47bf42cd on Nov 30, 2021
- Munkybooty referenced this in commit d1894b1710 on Nov 30, 2021
- DrahtBot locked this on Feb 15, 2022
Labels