Add 'mempool' P2P command, and extend 'getdata' behavior #1641

pull jgarzik wants to merge 1 commits into bitcoin:master from jgarzik:mempool changing 3 files +37 −4

jgarzik commented at 10:08 PM on July 31, 2012: contributor

Add 'mempool' P2P command, and extend 'getdata' behavior to permit downloading of mempool transactions from the remote peer.

Add 'mempool' P2P command, and extend 'getdata' behavior

to permit downloading of mempool transactions from the remote peer.

05a85b2b38

jgarzik commented at 6:53 PM on August 1, 2012: contributor

@gmaxwell was asking about testing. This was tested successfully with a one-line pynode patch (pynode HEAD deb07f51435cd0d18596bddfee28e337a5a6454e). pynode issues 'mempool' at startup, and fills its own mempool with the returned results.

--- a/node.py
+++ b/node.py
@@ -238,6 +238,7 @@ class NodeConn(asyncore.dispatcher):
                        self.send_message(msg_verack(self.ver_send))
                        if self.ver_send >= CADDR_TIME_VERSION:
                                self.send_message(msg_getaddr(self.ver_send))
+                       self.send_message(msg_mempool())
                        self.send_getblocks()

jgarzik commented at 5:56 PM on August 2, 2012: contributor

Random thought: miners may want this, to "prime the pump" after restarting their bitcoind. There is the incentive to capture every fee-paying transactions, after all.
BitcoinPullTester commented at 9:08 PM on August 8, 2012: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/05a85b2b38d516a8701f684fcd2ab99f3e5b462d for binaries and test log.
sipa commented at 3:44 PM on August 13, 2012: member

ACK on the changes, but maybe there must at least be some discussion about adding this, and the protocol version change involved. An alternative would be using a service bit (I don't personally think that is preferable), but people may have other opinions.

I would expect the startup sequence to also send a mempool command to another node, in case it reports protocol version 60002 or higher?
BitcoinPullTester commented at 7:19 PM on August 16, 2012: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/05f891636199c36e1639fb95f5e92445eea9e97f for binaries and test log.
jgarzik commented at 8:04 PM on August 17, 2012: contributor

Specification: https://en.bitcoin.it/wiki/BIP_0035
sipa commented at 2:16 PM on August 20, 2012: member

ACK
gavinandresen commented at 2:20 PM on August 20, 2012: contributor

ACK
jgarzik referenced this in commit b3a570d158 on Aug 20, 2012
jgarzik merged this on Aug 20, 2012
jgarzik closed this on Aug 20, 2012
suprnurd referenced this in commit d3829e55b1 on Dec 5, 2017
suprnurd referenced this in commit 72b221f745 on Dec 5, 2017
unknown commented at 11:06 AM on June 26, 2018: none

1989
DrahtBot locked this on Sep 8, 2021

Contributors