0.18: wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransaction #16414

1. 
   promag commented at 3:45 PM on July 18, 2019: member

   Backports #16322 and #16257.

2. promag force-pushed on Jul 18, 2019
3. promag force-pushed on Jul 18, 2019
4. DrahtBot added the label Docs on Jul 18, 2019
5. DrahtBot added the label Tests on Jul 18, 2019
6. DrahtBot added the label TX fees and policy on Jul 18, 2019
7. DrahtBot added the label Wallet on Jul 18, 2019
8. fanquake added the label Backport on Jul 18, 2019
9. fanquake removed the label Docs on Jul 18, 2019
10. fanquake removed the label TX fees and policy on Jul 18, 2019
11. fanquake added this to the milestone 0.18.1 on Jul 18, 2019
12. fanquake requested review from Sjors on Jul 19, 2019
13. fanquake requested review from MarcoFalke on Jul 19, 2019
14. 
    Sjors commented at 7:25 AM on July 20, 2019: member

    ACK modulo the wip: commit messages. Description should mention this also backports #16257.

15. 
    promag commented at 5:50 PM on July 20, 2019: member

    Is this 0.18.2 then?

16. 
    fanquake commented at 3:24 AM on July 25, 2019: member

    Is this 0.18.2 then?

    Unless there happens to be an rc2, and this is merged in the interim, I think that will likely be the case.

    Given that this is backporting to the 0.18 branch, instead of adding the doc/release-notes-0.18.1-16257.md file, can you just add the changes directly to release-notes.md? You might have to rebase, as the release notes have just been updated for 0.18.1.

17. fanquake removed this from the milestone 0.18.1 on Aug 2, 2019
18. fanquake added this to the milestone 0.18.2 on Aug 2, 2019
19. fanquake requested review from meshcollider on Aug 14, 2019
20. fanquake requested review from achow101 on Aug 14, 2019
21. 
    meshcollider commented at 9:44 PM on August 16, 2019: contributor

    Why is the commit message wip? Is this ready for review?

22. promag force-pushed on Aug 18, 2019
23. 
    promag commented at 11:54 PM on August 18, 2019: member

    Dropped wip prefix.

24. 
    Sjors commented at 8:40 AM on August 19, 2019: member

    ACK 7397275b4a7571eb09f2e16539b72b4354049b90

25. 
    fanquake commented at 12:49 PM on August 19, 2019: member

    This needs a rebase and the commits need the backport metadata (Github-Pull: & Rebased-From:) added. See the backport.py script.

26. fanquake added the label Needs rebase on Aug 19, 2019
27. 0.18: [wallet] abort when attempting to fund a transaction above maxtxfee

    FundTransaction calls GetMinimumFee which, when the fee rate is absurdly high, quietly reduced the fee to -maxtxfee. Becaue an absurdly high fee rate is usually the result of a fat finger, aborting seems safer behavior.
    
    Github-Pull: #16257
    Rebased-From: 806b0052c3b45415862f74f20ba5f389e5b673de

    8f354ced6e
28. 0.18: wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransaction

    Github-Pull: #16322
    Rebased-From: 5c1b9714cb0a13be28324f91f4ec9ca66a1de8c7

    a11dbaa547
29. 0.18: test: Add test for maxtxfee option

    Github-Pull: #16322
    Rebased-From: 0d101a340c44841cbbc5982d55354b1787bc39e2

    d3b3bb8c9f
30. promag force-pushed on Aug 25, 2019
31. DrahtBot removed the label Needs rebase on Aug 25, 2019
32. laanwj referenced this in commit 1659b9b099 on Sep 12, 2019
33. 
    promag commented at 9:01 AM on September 22, 2019: member

    Ping.

34. 
    Sjors commented at 12:40 PM on September 23, 2019: member

    re-ACK d3b3bb8c9fb3a2ff1cd3a8776552c649aaf19dc2

35. MarcoFalke removed the label Tests on Sep 23, 2019
36. 
    MarcoFalke commented at 1:32 PM on September 23, 2019: member

    ACK d3b3bb8c9fb3a2ff1cd3a8776552c649aaf19dc2 (did the backport myself, arrived at the same result)

    <details><summary>Show signature and timestamp</summary>

    Signature:

    -----BEGIN PGP SIGNED MESSAGE-----
    Hash: SHA512
    
    ACK d3b3bb8c9fb3a2ff1cd3a8776552c649aaf19dc2 (did the backport myself, arrived at the same result)
    -----BEGIN PGP SIGNATURE-----
    
    iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
    pUgocwv/bfvARaya5du9b8Tamq0D+dRpoy6FdepDukCHC8NvuekeIxucmHUz7LhJ
    UdDwzVSL8v+VGSJ2G6FtLfEzMVJzYdZDak08yarUxJT5vHnxI91fULAvNbXG/+7l
    3silywwBoei32t3v3WV/Lgth6xHIWHVumpyjLCJjvB3gp7amEbcKc9KqlvSTvYfg
    EWRrtO2RVt7MRduI99m/b+FMuMBY83lkhMBjyFJpD7cmqGtN3WGxxw/IiY0Xu78y
    bMt/ELGHTS3AgelOj4rEZwAiRHW+iCgEzHp0Mzn2OvaI6LzsNL0cU/5MKw+sFJzy
    zTGOfWpKj+bXlZtpYwr2F9WDh0GF8Fw9RO/w6pjtulTxGbAeD6jtrz8ko99md8kh
    RzzNaJrnlddu3fNPe0wGYDIG04eEJPl4ZLBmjmJ44F2m/A2o+/GOJdvs2kOPgfhL
    4/JZb32CxJmFQwbYhd85TE3PBFtGQpUalKu/MS1Tx/TGI16kSdztgqkdkGbFWDsN
    2zqsw7x9
    =F6GX
    -----END PGP SIGNATURE-----
    

    Timestamp of file with hash 95092eee457eb227f864af6a5b5dcb82a1ac2386c8b2dffd2bd4ed4ff7edade7 -

    </details>

37. MarcoFalke referenced this in commit 3b04221183 on Sep 23, 2019
38. MarcoFalke merged this on Sep 23, 2019
39. MarcoFalke closed this on Sep 23, 2019

    ---

40. promag deleted the branch on Sep 23, 2019
41. MarcoFalke locked this on Dec 16, 2021

Review Requested
Sjorsmeshcolliderachow101MarcoFalke

Milestone
0.18.2