No reason for this class to exist if it doesn't have any code to run in the destructor. e10e1e8db043e9b7c113e07faf408f337c1b732d from #16208 recently removed the destructor code that would return an unused key if the transaction wasn't committed.
This is just cleanup, there's no change in behavior.
No reason for this class to exist if it doesn't have any code to run in the
destructor. e10e1e8db043e9b7c113e07faf408f337c1b732d from
https://github.com/bitcoin/bitcoin/pull/16208 recently removed code destructor
code that would return an unused key if the transaction wasn't committed.
utACK 4d94916. Successfully built both bitcoind and bitcoin-qt. PendingWalletTx was only a wrapper to enforce call to ReturnDestination if CommitTransaction doesn't KeepDestination before.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
ACK 4d94916f0dda535cb69b538ee4e3fffb5b033c87, refactor looks good to me.
(restarted appveyor)
utACK 4d94916f0dda535cb69b538ee4e3fffb5b033c87