'Version used' of protobuf in doc/dependencies.md not correct? #16427

issue davereikher opened this issue on July 20, 2019
  1. davereikher commented at 1:05 PM on July 20, 2019: contributor

    I think there is a mistake in the 'Version used' column of protobuf in doc/dependencies.md. It says 2.6.1, but after installing this version and trying to compile Bitcoin Core on Ubuntu 16.04.1, I got the following error:

    Making all in src
    make[1]: Entering directory '/home/dave/projects/bitcoin/src'
    make[2]: Entering directory '/home/dave/projects/bitcoin/src'
    make[3]: Entering directory '/home/dave/projects/bitcoin'
    make[3]: Leaving directory '/home/dave/projects/bitcoin'
      CXX      qt/qt_libbitcoinqt_a-bitcoin.o
    In file included from ./qt/paymentrequestplus.h:10:0,
                     from ./qt/paymentserver.h:40,
                     from qt/bitcoin.cpp:26:
    ./qt/paymentrequest.pb.h:10:40: fatal error: google/protobuf/port_def.inc: No such file or directory
    compilation terminated.
    Makefile:8613: recipe for target 'qt/qt_libbitcoinqt_a-bitcoin.o' failed
    make[2]: *** [qt/qt_libbitcoinqt_a-bitcoin.o] Error 1
    make[2]: Leaving directory '/home/dave/projects/bitcoin/src'
    Makefile:13144: recipe for target 'all-recursive' failed
    make[1]: *** [all-recursive] Error 1
    make[1]: Leaving directory '/home/dave/projects/bitcoin/src'
    Makefile:776: recipe for target 'all-recursive' failed
    make: *** [all-recursive] Error 1
    

    Following the last comment here: https://github.com/protocolbuffers/protobuf/issues/5868, I installed 3.7.0 and managed to compile. It took me a while to sort this out, so if it is indeed wrong and not my mistake, I believe it should be fixed to save people time.

  2. fanquake added the label Docs on Jul 20, 2019
  3. fanquake commented at 1:22 PM on July 20, 2019: member

    The versions used is correct. 2.6.1 is used in our depends system (used for building dependencies for all release binaries): https://github.com/bitcoin/bitcoin/blob/master/depends/packages/protobuf.mk. You can also use it to build dependencies before compiling.

  4. davereikher commented at 4:00 PM on July 20, 2019: contributor

    Yes, sorry for my ignorance. I compiled it after running the depends system and everything worked fine.

  5. davereikher closed this on Jul 20, 2019

  6. DrahtBot locked this on Dec 16, 2021
Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-22 18:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me