build: remove qt libjpeg check from bitcoin_qt.m4 #16441

pull fanquake wants to merge 4 commits into bitcoin:master from fanquake:remove-qt-libjpeg-check changing 3 files +7 −9
  1. fanquake commented at 7:58 am on July 23, 2019: member

    When gitian building on Windows I’m seeing:

    0checking for Qt 5... yes
1checking for > Qt 5.7... yes
2checking for main in -limm32... yes
3checking for main in -lz ... yes
4checking for library containing jpeg_create_decompress ... configure: WARNING: libjpeg not found. Assuming qt has it built-in
5no
6checking for library containing png_error ... -lqtlibpng
7checking for library containing pcre2_match_16... -lqtpcre2
8checking for library containing hb_ot_tags_from_script ... -lqtharfbuzz

    We are passing -qt-libjpeg to Qt: https://github.com/bitcoin/bitcoin/blob/e6e99d4f757f2e5052f0cc68951c75e91e4753e3/depends/packages/qt.mk#L66 but I dont think we are doing anything with jpeg related regardless?

  2. fanquake added the label Build system on Jul 23, 2019
  3. fanquake added the label Needs gitian build on Jul 23, 2019
  4. fanquake requested review from theuni on Jul 23, 2019
  5. fanquake requested review from dongcarl on Jul 23, 2019
  6. fanquake renamed this:
    Remove qt libjpeg check from bitcoin_qt.m4
    build: remove qt libjpeg check from bitcoin_qt.m4
    on Jul 23, 2019
  7. theuni dismissed
  8. theuni commented at 5:49 pm on July 23, 2019: member

    Concept ACK. IIRC we used some jpegs ages ago, but since removal this is overdue.

    Could you switch to the qt config to -no-jpeg as well? It shouldn’t affect the end-result in any meaningful way because all of the unused jpeg stuff should be stripped out by the linker anyway, but we can at least avoid compiling libjpeg as part of the qt build.

  9. dongcarl commented at 6:21 pm on July 23, 2019: member
    Concept ACK, agree that we should change the qt config to -no-jpeg, and also remove libjpeg from doc/dependencies.md
  10. fanquake force-pushed on Jul 24, 2019
  11. build: disable libjpeg in qt 98a64bd296
  12. build: remove jpeg lib check from bitcoin_qt.m4 0aeb98ac1f
  13. doc: fix typo in bitcoin_qt.m4 comment 1bb1661a40
  14. doc: remove line numbers from qt package links f509e3b8ce
  15. fanquake force-pushed on Jul 24, 2019
  16. fanquake commented at 1:20 am on July 24, 2019: member
    Added -no-libjpeg to Qts configure flags, and removed jpeg from doc/dependencies.md. Also added a commit that removes the line numbers from the qt packages that we reference in there, as at the moment they are constantly incorrect.
  17. DrahtBot commented at 2:29 am on July 24, 2019: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #16381 (Set minimum required Boost to 1.53.0 by hebasto)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  18. laanwj commented at 1:15 pm on July 24, 2019: member

    Good catch, I struggle to remember what we ever needed jpeg for, so I searched history:

    0 delete mode 100644 src/qt/res/images/splash2.jpg

    it was removed in 2013 in f9124587ccea723dbd743e3877a7071fbb6c5732

    ACK f509e3b8ce0c5652e85ce26545f7ed94689f46ab

  19. laanwj approved
  20. promag commented at 10:21 pm on July 26, 2019: member
    ACK f509e3b8ce0c5652e85ce26545f7ed94689f46ab.
  21. DrahtBot commented at 8:52 pm on July 28, 2019: member

    Gitian builds for commit febf3a856bcfb8fef2cb4ddcb8d1e0cab8a22580 (master):

    Gitian builds for commit bdff4477e5f3129d03aff7e2ecbc1c0ffbdba77a (master and this pull):

  22. DrahtBot removed the label Needs gitian build on Jul 28, 2019
  23. laanwj merged this on Jul 29, 2019
  24. laanwj closed this on Jul 29, 2019
  25. laanwj referenced this in commit 29220250c1 on Jul 29, 2019
  26. fanquake deleted the branch on Aug 11, 2019
  27. deadalnix referenced this in commit 5a7ef9c4ec on Apr 2, 2020
  28. Munkybooty referenced this in commit 0b0be71df4 on Nov 16, 2021
  29. Munkybooty referenced this in commit d55b3bff18 on Nov 18, 2021
  30. Munkybooty referenced this in commit 3f923dd4ca on Nov 24, 2021
  31. Munkybooty referenced this in commit ad7d067e0b on Nov 30, 2021
  32. Munkybooty referenced this in commit 2ddb5ff428 on Dec 15, 2021
  33. MarcoFalke locked this on Dec 16, 2021


fanquake theuni dongcarl DrahtBot laanwj promag


dongcarl

Labels
Build system

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 15:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me