test: Skip flaky p2p_invalid_messages test on macOS #16445

pull fjahr wants to merge 1 commits into bitcoin:master from fjahr:mac_test changing 1 files +18 −10

fjahr commented at 8:00 PM on July 23, 2019: member

This mitigates #15400

I had a look into the issue today and this seems to be the best we can do given that the root causes some unexpected custom error code from the macOS kernel that python/asyncio doesn't know how to handle properly yet.
test: Skip flaky p2p_invalid_messages test on macOS c3dfc91032
MarcoFalke commented at 8:05 PM on July 23, 2019: member

Concept ACK. Would be nice if someone with a mac could verify that this test is flaky before this commit and not flaky after this commit.
DrahtBot added the label Tests on Jul 23, 2019
fanquake commented at 12:58 AM on July 24, 2019: member

cc @IlyasRidhuan
IlyasRidhuan commented at 1:32 AM on July 24, 2019: none

The testing I did as part of #14814 indicates that it is macOS-specific and is related to asyncio. This does not affect Linux.

Concept ACK - also in line with older comments #14522 (comment) regarding this test.
fanquake commented at 5:47 AM on July 24, 2019: member

Concept ACK

Would be nice if someone with a mac could verify that this test is flaky before this commit and not flaky after this commit.

I see the p2p_invalid_messages randomly fail quite frequently (using master). I ran the p2p_invalid_messages test in a loop for a while with this change I haven't seen a single failure.
MarcoFalke merged this on Jul 24, 2019
MarcoFalke closed this on Jul 24, 2019
MarcoFalke referenced this in commit 0626b8cbdf on Jul 24, 2019
jamesob commented at 2:40 PM on July 24, 2019: member

Post-merge ACK - thanks for fixing this.
random-zebra referenced this in commit bffe509aed on Jun 28, 2021
kittywhiskers referenced this in commit 15ddc961f7 on Aug 5, 2021
kittywhiskers referenced this in commit a4bbaaac18 on Aug 5, 2021
kittywhiskers referenced this in commit 5142c65957 on Aug 9, 2021
kittywhiskers referenced this in commit cc2c96e87d on Aug 12, 2021
kittywhiskers referenced this in commit 521db51ae3 on Aug 22, 2021
kittywhiskers referenced this in commit 1f02c4a61c on Aug 30, 2021
kittywhiskers referenced this in commit 47e1d4701e on Nov 1, 2021
kittywhiskers referenced this in commit 907101098d on Nov 3, 2021
pravblockc referenced this in commit 58e0648a2a on Nov 18, 2021
DrahtBot locked this on Dec 16, 2021

Contributors

Labels

Linked (view graph)

#15400 Tests: p2p_invalid_messages test can fail in runner due to stderr text when socket write buffer flushed