refactoring: Use direct list initialization for Arg struct #16469

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:20190726-remove-arg-ctor changing 2 files +1 −3

hebasto commented at 7:56 PM on July 26, 2019: member

Using a direct list initialization for struct Arg objects makes the constructor needless.

This PR has been split out from #16097 (see: #16097 (comment)).
refactoring: Use direct list initialization b89eb79b3a
hebasto commented at 8:02 PM on July 26, 2019: member

ping @ryanofsky @promag

in src/util/system.cpp:550 in b89eb79b3a

 546 | @@ -547,7 +547,7 @@ void ArgsManager::AddArg(const std::string& name, const std::string& help, const
 547 |  
 548 |      LOCK(cs_args);
 549 |      std::map<std::string, Arg>& arg_map = m_available_args[cat];
 550 | -    auto ret = arg_map.emplace(name.substr(0, eq_index), Arg(name.substr(eq_index, name.size() - eq_index), help, debug_only));
 551 | +    auto ret = arg_map.emplace(name.substr(0, eq_index), Arg{name.substr(eq_index, name.size() - eq_index), help, debug_only});

promag commented at 8:04 PM on July 26, 2019:

Can't test at the moment but I think you could drop Arg?

hebasto commented at 8:16 PM on July 26, 2019:

Can't test at the moment but I think you could drop Arg?

It won't work if a type is automatically deduced: auto ret = ...

MarcoFalke commented at 8:30 PM on July 26, 2019:

I'd prefer to keep it. Three ascii chars are not a bloat

promag commented at 8:04 PM on July 26, 2019: member

ACK.

in src/util/system.h:149 in b89eb79b3a

 146 | @@ -147,8 +147,6 @@ class ArgsManager
 147 |          std::string m_help_param;
 148 |          std::string m_help_text;
 149 |          bool m_debug_only;

MarcoFalke commented at 8:29 PM on July 26, 2019:

Can those be const to enforce setting them in the constructor?

DrahtBot added the label Refactoring on Jul 26, 2019
DrahtBot added the label Utils/log/libs on Jul 26, 2019
hebasto closed this on Jul 27, 2019
hebasto deleted the branch on Aug 2, 2019
DrahtBot locked this on Dec 16, 2021

Contributors

hebasto

promag

MarcoFalke

Labels

Refactoring Utils/log/libs

Linked (view graph)

#16097 Refactor: Add Flags enum to ArgsManager class