[mempool] log correct messages when CPFP fails #16471

pull jnewbery wants to merge 1 commits into bitcoin:master from jnewbery:2019-07-fix-CalculateMempoolAncestors-logging changing 2 files +8 −6
  1. jnewbery commented at 8:23 pm on July 26, 2019: member
    Fixes a logging issue introduced in #15681
  2. [mempool] log correct messages when CPFP fails 42a5e912ee
  3. jnewbery commented at 8:23 pm on July 26, 2019: member
    Reported here: #15681 (review)
  4. TheBlueMatt commented at 8:32 pm on July 26, 2019: member
    Right, its somewhat unclear what the correct log message should be. If you were trying to use the carve-out you want the original version, which I somewhat naively assumed would be correct, but I think you’re right, makes more sense to use the original one. utACK.
  5. DrahtBot added the label Tests on Jul 26, 2019
  6. DrahtBot added the label Validation on Jul 26, 2019
  7. DrahtBot commented at 11:07 pm on July 26, 2019: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #16421 (Conservatively accept RBF bumps bumping one tx at the package limits by TheBlueMatt)
    • #16401 (Package relay by sdaftuar)
    • #16400 ([refactor] Rewrite AcceptToMemoryPoolWorker() using smaller parts by sdaftuar)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  8. laanwj commented at 4:55 pm on July 29, 2019: member
    ACK 42a5e912ee4e91a5191d659588f0605e1ada2f33 (+utACK from bluematt that isn’t registered because it has no commit id)
  9. laanwj merged this on Jul 29, 2019
  10. laanwj closed this on Jul 29, 2019

  11. laanwj referenced this in commit 68da54987d on Jul 29, 2019
  12. jnewbery deleted the branch on Jul 29, 2019
  13. Munkybooty referenced this in commit 8dffdd471a on Nov 16, 2021
  14. MarcoFalke locked this on Dec 16, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-24 09:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me