Added in #14573 but not used, so begone.
gui: Remove unused RPCConsole::tabFocus #16514
pull promag wants to merge 1 commits into bitcoin:master from promag:2019-07-remove-unused-tabfocus changing 2 files +0 −6-
promag commented at 10:35 PM on July 31, 2019: member
-
gui: Remove unused RPCConsole::tabFocus b078067b9c
- fanquake added the label GUI on Jul 31, 2019
-
emilengler commented at 10:42 PM on July 31, 2019: contributor
Maybe it's better to comment it out so we can use it if may need it in future (If that's a thing in this project).
-
promag commented at 10:46 PM on July 31, 2019: member
IMO better is to kill unused code. It's also easy to bring this back, if needed.
-
practicalswift commented at 10:47 PM on July 31, 2019: contributor
utACK b078067b9c2aa1d259395198005fab470ea4e39d
-
emilengler commented at 11:43 PM on July 31, 2019: contributor
It perfectly removes it, utACK
-
promag commented at 11:52 PM on July 31, 2019: member
@practicalswift @emilengler please take a new look at CONTRIBUTING.md#peer-review, it was recently updated in #16149.
-
emilengler commented at 11:57 PM on July 31, 2019: contributor
@promag Didn't knew it, then Concept ACK Approach ACK
-
hebasto commented at 9:08 AM on August 1, 2019: member
ACK b078067b9c2aa1d259395198005fab470ea4e39d I have not tested the code, but I have reviewed it and it looks OK, I agree it can be merged.
-
laanwj commented at 10:41 AM on August 1, 2019: member
ACK b078067b9c2aa1d259395198005fab470ea4e39d, there's nothing really to test here
Maybe it's better to comment it out so we can use it if may need it in future (If that's a thing in this project).
I think if we don't expect it to be necessary at some point it's better to remove it. (I'm generally for removing dead code unless it breaks API expectations)
- laanwj merged this on Aug 1, 2019
- laanwj closed this on Aug 1, 2019
- laanwj referenced this in commit 75656988ac on Aug 1, 2019
- jasonbcox referenced this in commit 066a318ae6 on Oct 12, 2020
- ftrader referenced this in commit 459b3bb5d0 on Apr 14, 2021
- Munkybooty referenced this in commit 72d7426df6 on Nov 25, 2021
- Munkybooty referenced this in commit b08bcee9fd on Nov 30, 2021
- DrahtBot locked this on Dec 16, 2021
