guix: Change manifest to use channels and inferiors #16519

1. 
   dongcarl commented at 4:49 pm on August 1, 2019: member

   0This change pins the packages that make up our Guix environment, making
   1them reproducible regardless of the current version of Guix that the
   2user is running. It should eliminate the `guix pull' step of the Guix
   3build process.
   

   ---

   Not ready for merge yet, as we’re waiting on https://issues.guix.gnu.org/issue/36777 to be resolved. The issue is that inferiors don’t work for a certain range of Guix versions, which is a minor issues, but should be addressed before we do this.

   Also, this currently relies on my repo located here: https://github.com/dongcarl/bitcoin-guix, which is fine because we do similar things in other places, but I’d like to move this repo under the bitcoin-core org if at all possible.

2. guix: Change manifest to use channels and inferiors

   This change pins the packages that make up our Guix environment, making
   them reproducible regardless of the current version of Guix that the
   user is running. It should eliminate the `guix pull' step of the Guix
   build process.

   d4e0694feb
3. dongcarl force-pushed on Aug 1, 2019
4. DrahtBot added the label Scripts and tools on Aug 1, 2019
5. fanquake added the label Build system on Aug 1, 2019
6. 
   fanquake commented at 8:49 pm on August 1, 2019: member

   Concept ACK

   but I’d like to move this repo under the bitcoin-core org if at all possible.

   That should be perfectly possible.

7. 
   laanwj commented at 12:13 pm on September 16, 2019: member

   Concept ACK
8. 
   laanwj commented at 12:14 pm on September 16, 2019: member

   Also, this currently relies on my repo located here: https://github.com/dongcarl/bitcoin-guix, which is fine because we do similar things in other places, but I’d like to move this repo under the bitcoin-core org if at all possible.

   Could it be part of bitcoin-core/packaging, which is the umbrella repository for all things distribution packaging, or does this really need its own separate repo?

9. 
   MarcoFalke commented at 12:47 pm on September 16, 2019: member

   According to https://guix.gnu.org/manual/en/html_node/Channels.html

   A channel specifies a URL and branch of a Git repository to be deployed

   So yes, it could be a branch in the https://github.com/bitcoin-core/packaging git repo. (Could even be the master branch when we add a meta-data file .guix-channel to specify the subdir it is in)

10. 
    dongcarl commented at 2:50 pm on September 16, 2019: member

    It doesn’t need to be its own separate repo. Marco is right, we can do branches or even a subdir (as long as it’s in a git repository). I’m not particular about what exactly to do so either of you can make a call and I’ll make it happen.

    I’ll update this accordingly.

11. 
    MarcoFalke commented at 4:01 pm on September 16, 2019: member

    subdir (as long as it’s in a git repository)

    So it could be put in either https://github.com/bitcoin/bitcoin or https://github.com/bitcoin-core/packaging/. Shouldn’t matter much, I think?

12. 
    DrahtBot commented at 11:25 pm on October 21, 2019: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #17351 (doc: Fix some misspellings by RandyMcMillan)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

13. 
    dongcarl commented at 5:02 pm on October 25, 2019: member

    This PR really shines once it can eliminate the guix pull step of the Guix build process, this is currently not possible because the last release of Guix did not have a command-line flag that I intend to use (unfortunately you can’t use inferiors to travel in time to pick up new command-line flags… yet…).

    TLDR: Waiting for new Guix release, after which this will be very useful.

14. laanwj added this to the "PRs" column in a project

    ---

15. 
    dongcarl commented at 9:33 pm on January 23, 2020: member

    Closed in favor of #17933
16. dongcarl closed this on Jan 23, 2020

    ---

17. fanquake referenced this in commit 3774281327 on Jan 28, 2020
18. fanquake referenced this in commit ed3b8eada8 on Apr 12, 2020
19. sidhujag referenced this in commit 9543357506 on Apr 13, 2020
20. fanquake moved this from the "PRs" to the "Done" column in a project

    ---

21. PhotoshiNakamoto referenced this in commit ad0ab16751 on Dec 13, 2021
22. DrahtBot locked this on Feb 15, 2022

Contributors
dongcarl fanquake laanwj MarcoFalke DrahtBot

Labels
Build system Scripts and tools