B: Get rid of Params().RequireStandard() #16527

1. 
   jtimon commented at 11:14 pm on August 1, 2019: contributor

   Based on #16524 Alternative to #16526

   This goes further and just like in #16524 it removes the different defaults for each chain.

   In my opinion, one thing is to want to prevent people from shooting themselves in the food like AllowAcceptNonstd()/IsTestChain() allows for mainnet and a very different one is having per chain defaults for each parameter.

   testnet3 and regtest users will now need to modify their config files, at most, in the following way:

    0[main]
    1+acceptnonstdtxn=0
    2...
    3
    4[test]
    5+acceptnonstdtxn=1
    6...
    7
    8[regtest]
    9+acceptnonstdtxn=0
   10...
   

   I don’t think that’s much to ask from the advanced users regtest and testnet users are supposed to be. Maybe this is different for testnet3, I would like to hear why.

2. DrahtBot added the label Validation on Aug 1, 2019
3. DrahtBot added the label Wallet on Aug 1, 2019
4. fanquake added the label Needs Conceptual Review on Aug 1, 2019
5. 
   DrahtBot commented at 11:33 pm on August 1, 2019: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #17037 (Testschains: Many regtests with different genesis and default datadir by jtimon)
   • #17032 (Tests: Chainparams: Make regtest almost fully customizable by jtimon)
   • #16770 (Chainparams: Rename IsTestChain() to AllowAcceptNonstd() by jtimon)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

6. jtimon renamed this:
   Get rid of Params().RequireStandard()
   B: Get rid of Params().RequireStandard()
   on Aug 1, 2019
7. DrahtBot added the label Needs rebase on Aug 2, 2019
8. jtimon force-pushed on Aug 7, 2019
9. 
   jtimon commented at 2:50 am on August 7, 2019: contributor

   Rebased
10. DrahtBot removed the label Needs rebase on Aug 7, 2019
11. jtimon force-pushed on Aug 7, 2019
12. Chainparams: Get rid of Params().RequireStandard() b11d740863
13. jtimon force-pushed on Aug 31, 2019
14. 
    jtimon commented at 4:17 pm on August 31, 2019: contributor

    Decoupled from #16524
15. 
    MarcoFalke commented at 3:01 pm on October 3, 2019: member

    This means that non std txs aren’t propagated on testnet, so tend to NACK
16. 
    jtimon commented at 8:11 pm on October 3, 2019: contributor

    Well, only if users don’t set acceptnonstdtxn=1, we could say it in the release notes. But yeah, that’s, I think, the best argument against this.
17. 
    luke-jr commented at 11:01 pm on October 8, 2019: member

    It makes sense to default to -acceptnonstdtxn=1 on testnet. But it’s also just testnet, so don’t care too strongly.
18. 
    jtimon commented at 11:38 am on February 4, 2020: contributor

    Closing for now due to lack of interest.
19. jtimon closed this on Feb 4, 2020

    ---

20. DrahtBot locked this on Feb 15, 2022

Contributors
jtimon DrahtBot MarcoFalke luke-jr

Labels
Wallet Validation Needs Conceptual Review