test: Explain why -whitelist is used in feature_fee_estimation #16535

1. 
   MarcoFalke commented at 3:09 pm on August 2, 2019: member
2. test: Format feature_fee_estimation with pep8 faff85a69a
3. fanquake added the label Tests on Aug 2, 2019
4. MarcoFalke force-pushed on Aug 2, 2019
5. test: Explain why -whitelist is used in feature_fee_estimation

   Also, Remove seemingly unused and undocumented -maxorphantx=1000

   fa76285fdd
6. MarcoFalke force-pushed on Aug 2, 2019
7. 
   DrahtBot commented at 4:54 pm on August 2, 2019: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #16549 ([WIP] UI external signer support (e.g. hardware wallet) by Sjors)
   • #16546 ([WIP] External signer support - Wallet Box edition by Sjors)
   • #16528 ([WIP] Native Descriptor Wallets (take 2) by achow101)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

8. 
   practicalswift commented at 5:05 pm on August 2, 2019: contributor

   ACK fa76285fddac613c518e73b35a7486ad2ab4b992 – diff looks correct
9. 
   Sjors commented at 10:54 am on August 6, 2019: member

   ACK fa76285, every bit of clarification helps. It’s clear that without -whitelist the test becomes extremely slow (it does pass).

   That said, the title is overselling this PR a bit :-)

   I still don’t really understand what whitelist is doing. It seems to have something to do with BIP 35. Apparently whitelisting a node means we spam it more? I also understand it only applies to inbound nodes (see #9923).

   To make it more clear / mysterious which whitelist feature this test relies on, you could set -whitelistforcerelay=0 and -whitelistrelay=0 (it will still run quick).

10. 
    MarcoFalke commented at 12:33 pm on August 6, 2019: member

    That said, the title is overselling this PR a bit :-)

    Heh, yeah I think it was an oversight to only set whitelist for the first node. So I added it to the others as well.

    To make it more clear / mysterious which whitelist feature this test relies on, you could set -whitelistforcerelay=0 and -whitelistrelay=0 (it will still run quick).

    I hope I can make it more specific after #16248.

11. MarcoFalke referenced this in commit b725979a11 on Aug 6, 2019
12. MarcoFalke merged this on Aug 6, 2019
13. MarcoFalke closed this on Aug 6, 2019

    ---

14. MarcoFalke deleted the branch on Aug 6, 2019
15. codablock referenced this in commit 64fc8a4c03 on Jan 4, 2020
16. codablock referenced this in commit 9fbf327646 on Jan 4, 2020
17. UdjinM6 referenced this in commit 88da298082 on Jan 4, 2020
18. ckti referenced this in commit c1f7fbe5c8 on Mar 28, 2021
19. gades referenced this in commit bc788186e7 on Jun 26, 2021
20. Munkybooty referenced this in commit f4a7273a7a on Nov 25, 2021
21. DrahtBot locked this on Dec 16, 2021

Contributors
MarcoFalke DrahtBot practicalswift Sjors

Labels
Tests