test: Add unit test for AddTimeData #16563

  52 | +BOOST_AUTO_TEST_CASE(addtimedata)
  53 | +{
  54 | +    BOOST_CHECK_EQUAL(GetTimeOffset(), 0);
  55 | +
  56 | +    //Part 1: Add large offsets to test a warning message that our clock may be wrong.
  57 | +    MultiAddTimeData(3, DEFAULT_MAX_TIME_ADJUSTMENT + 1); //filter size 4, initialized with 0

---

  84 | +
  85 | +    // After the number of offsets has reached MAX_SAMPLES -1 (=199), nTimeOffset will never change
  86 | +    // because it is only updated when the number of elements in the filter becomes odd. It was decided
  87 | +    // not to fix this because it prevents possible attacks. See the comment in AddTimeData() or issue #4521
  88 | +    // for a more detailed explanation.
  89 | +    MultiAddTimeData(MAX_SAMPLES, 200); // filter median is 200, but nTimeOffset will not change

---

  37 | @@ -34,4 +38,62 @@ BOOST_AUTO_TEST_CASE(util_MedianFilter)
  38 |      BOOST_CHECK_EQUAL(filter.median(), 7);
  39 |  }
  40 |  
  41 | +void MultiAddTimeData(int n, int64_t offset)

---

  37 | @@ -34,4 +38,62 @@ BOOST_AUTO_TEST_CASE(util_MedianFilter)
  38 |      BOOST_CHECK_EQUAL(filter.median(), 7);
  39 |  }
  40 |  
  41 | +void MultiAddTimeData(int n, int64_t offset)
  42 | +{
  43 | +    static int cnt = 0;
  44 | +    for (int i = 0; i < n; ++i) {
  45 | +        CNetAddr addr;
  46 | +        addr.SetInternal(std::to_string(++cnt));

---

  60 | +    noui_suppress();
  61 | +    MultiAddTimeData(1, DEFAULT_MAX_TIME_ADJUSTMENT + 1); //filter size 5
  62 | +    noui_reconnect();
  63 | +
  64 | +    std::string warning = GetWarnings("gui");
  65 | +    BOOST_CHECK(warning.find("clock is wrong") != std::string::npos);

---