Fix several issues in the Qt unit tests. #1658

pull TheBlueMatt wants to merge 4 commits into bitcoin:master from TheBlueMatt:qttest changing 5 files +15 −11

TheBlueMatt commented at 7:55 PM on August 6, 2012: member

No description provided.
TheBlueMatt commented at 1:23 PM on August 7, 2012: member

Please don't merge this yet, I'm gonna use to it test Jenkins' new pull-testing capabilities :) (this will fail because it makes bitcoin-qt_test compatible with Jenkins' build script, and bitcoin-qt_test currently fails)
Return !0 when qt tests fail. 026594e269
Fix Win32 compiling of qt/test/uritests.cpp 319236afa2

Fix Qt test cases by moving address checks to parseBitcoinURI

Makes sense in case bitcoin URIs eventually allow invalid addresses
as a part of some larger future payment scheme.

2bc15836be

BitcoinPullTester commented at 5:44 PM on August 7, 2012: none
The following is an automatic comment from the Bitcoin Pull Tester. If you believe it is in error, please contact jenkins@bluematt.me

This pull failed automatic sanity-tests! This could happen for one of several reasons:
1. It chanages paths in makefile.linux-mingw or otherwise changes build scripts in a way that made them incompatible with the automated testing scripts
2. It does not merge cleanly onto current master
3. It does not build on either Linux i386 or Win32 (via MinGW cross compile)
4. The test suite fails on either Linux i386 or Win32
You can find the test log and build output at http://jenkins.bluematt.me/pull-tester/fdf86649e3556d475967e49368d8266e460ecb91
laanwj commented at 6:49 PM on August 7, 2012: member

Cool, it works
BitcoinPullTester commented at 7:02 PM on August 7, 2012: none

Well it identifies everything as invalid so far, but it should be good for the positive now...just have to keep running the several hour test each time...
BitcoinPullTester commented at 8:35 PM on August 7, 2012: none
The following is an automatic comment from the Bitcoin Pull Tester. If you believe it is in error, please contact jenkins@bluematt.me

This pull failed automatic sanity-tests! This could happen for one of several reasons:
1. It chanages paths in makefile.linux-mingw or otherwise changes build scripts in a way that made them incompatible with the automated testing scripts
2. It does not merge cleanly onto current master
3. It does not build on either Linux i386 or Win32 (via MinGW cross compile)
4. The test suite fails on either Linux i386 or Win32
You can find the test log and build output at http://jenkins.bluematt.me/pull-tester/2bc15836bead1d5bdb8eca2db2525a9643cc4d0f
BitcoinPullTester commented at 9:54 PM on August 7, 2012: none
The following is an automatic comment from the Bitcoin Pull Tester. If you believe it is in error, please contact jenkins@bluematt.me

This pull failed automatic sanity-tests! This could happen for one of several reasons:
1. It chanages paths in makefile.linux-mingw or otherwise changes build scripts in a way that made them incompatible with the automated testing scripts
2. It does not merge cleanly onto current master
3. It does not build on either Linux i386 or Win32 (via MinGW cross compile)
4. The test suite fails on either Linux i386 or Win32
You can find the test log and build output at http://jenkins.bluematt.me/pull-tester/4f428abc6a4a52a930585f76accf7bd5fe6f8a38
Fix test_bitcoin build in makefile.linux-mingw c5f90cd88b
BitcoinPullTester commented at 12:18 AM on August 8, 2012: none

The following is an automatic comment from the Bitcoin Pull Tester. If you believe it is in error, please contact jenkins@bluematt.me

This pull passed automatic sanity-tests! This means it merges cleanly onto current master, builds and unit-tests pass You can find the test log and build output at http://jenkins.bluematt.me/pull-tester/c5f90cd88b61ff28327eed4981903bdf72027cc5
BitcoinPullTester commented at 12:41 AM on August 8, 2012: none

Now it works :)
jgarzik referenced this in commit 2c006b0b3e on Aug 8, 2012
jgarzik merged this on Aug 8, 2012
jgarzik closed this on Aug 8, 2012
laanwj commented at 5:39 AM on August 8, 2012: member

Woohoo!
suprnurd referenced this in commit 278cf144b3 on Dec 5, 2017
KolbyML referenced this in commit f6a1a6e0e3 on Dec 5, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

TheBlueMatt

BitcoinPullTester

laanwj