[QT] New filesave icon #16583

pull GChuf wants to merge 6 commits into bitcoin:master from GChuf:master changing 2 files +15 −6

GChuf commented at 4:41 PM on August 10, 2019: contributor

The old icon is the same as "receive.png"
[QT] New filesave icon 7a7378e448
Merge pull request #1 from gapeman/gapeman-patch-1
[QT] New filesave icon
0d35b39c59
hebasto commented at 5:04 PM on August 10, 2019: member

@gapeman Welcome! Screenshots "before" and "after" are appreciated in the PR description.
DrahtBot added the label GUI on Aug 10, 2019
emilengler commented at 6:12 PM on August 10, 2019: contributor

Concept NACK because I think that the current icon does this job. Also we are using icons from here and I think its better to keep using these icons
jonasschnelli commented at 7:36 PM on August 10, 2019: contributor

Looks not to bad. Either we use an icon from https://www.s-ings.com/typicons/ or you would need to put an entry into doc/assets-attribution.md (creator, license, etc.).

However, I think your new icon would require padding to not appear overly large.
Update copyright
Updated copyright, fixed typos.
3ab6c39073
[QT] New filesave icon 76d3ed7dce
Update copyright c95ad1d4dc
GChuf commented at 12:46 PM on August 11, 2019: contributor

I have padded the icon, and updated the copyright file. I've also noticed some mistakes in the copyright file (It's Stephen, not Stephan). Current licence file is under /contrib/debian/copyright and I'm not sure why - surely it would be better for it to stay in doc/assets-attribution.md?

p.s. Updated copyright 2 times because I accidentally removed "< >" symbols
Sjors commented at 4:21 PM on August 11, 2019: member

c95ad1d looks good, but please squash the commits

Would also be good to add a screenshot of the icon in context.
Update copyright 62ef83ecf1
GChuf commented at 8:42 PM on August 11, 2019: contributor

Closing this pull request, opening new one
GChuf closed this on Aug 11, 2019
emilengler commented at 8:43 PM on August 11, 2019: contributor

Ok... Why?
emilengler commented at 9:03 PM on August 11, 2019: contributor

See #16584
fanquake commented at 11:40 PM on August 11, 2019: member

In future please just squash and force push to the branch, rather than opening a new PR.
fanquake locked this on Aug 11, 2019

Contributors

Labels