build: Remove unused src/obj-test folder #16589

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:1908-buildNoSrcObjTest changing 1 files +0 −2
  1. MarcoFalke commented at 7:34 PM on August 12, 2019: member

    I believe this is no longer used after we switched from a makefile to autotools

  2. build: Remove unused src/obj-test folder fa4ee0ddf1
  3. MarcoFalke added the label Build system on Aug 12, 2019
  4. MarcoFalke added the label Needs gitian build on Aug 12, 2019
  5. emilengler commented at 7:37 PM on August 12, 2019: contributor

    A grep in the repository doesn't show any usages at this folder. Concept ACK https://github.com/bitcoin/bitcoin/pull/16589/commits/fa4ee0ddf1b5150a9dcdd3bb711d5a06220ecebb

  6. hebasto commented at 8:05 PM on August 12, 2019: member

    Do we need src/obj folder?

  7. MarcoFalke commented at 8:14 PM on August 12, 2019: member

    @hebasto

    • Quick version string hack that was never fixed #16588
  8. DrahtBot commented at 4:21 AM on August 14, 2019: member

    <!--a722867cd34abeea1fadc8d60700f111-->

    Gitian builds for commit b799ebcc17ea914b6e50f97f008f498ca31e0f36 (master):

    Gitian builds for commit dffb02a649e9225181752bb9154ae9e1f5a940fb (master and this pull):

  9. DrahtBot removed the label Needs gitian build on Aug 14, 2019
  10. fanquake commented at 8:45 AM on August 14, 2019: member

    Concept ACK. Looks like this folder and src/obj/test were related to the original addition of the Boost test framework in #356.

    src/obj/test was renamed to src/obj-test to workaround bug in older GNU Make in #777.

  11. laanwj commented at 8:52 AM on August 14, 2019: member

    Do we need src/obj folder?

    apparently yes

    Makefile.am:    @$(MKDIR_P) $(builddir)/obj
Makefile.am:    @$(top_srcdir)/share/genbuild.sh "$(abs_top_builddir)/src/obj/build.h" \
Makefile.am:nodist_libbitcoin_util_a_SOURCES = $(srcdir)/obj/build.h
Makefile.am:libbitcoinconsensus_la_CPPFLAGS = $(AM_CPPFLAGS) -I$(builddir)/obj -I$(srcdir)/secp256k1/include -DBUILD_BITCOIN_INTERNAL
  12. laanwj commented at 10:22 AM on August 14, 2019: member

    Though I don't think it needs to be in git. The build script creates it as necessary to put build.h in.

  13. MarcoFalke commented at 12:26 PM on August 14, 2019: member

    Again, for src/obj, please see:

    • Quick version string hack that was never fixed #16588
  14. MarcoFalke merged this on Aug 14, 2019
  15. MarcoFalke closed this on Aug 14, 2019
  16. MarcoFalke referenced this in commit 24f29790cd on Aug 14, 2019
  17. laanwj commented at 12:35 PM on August 14, 2019: member

    Again, for src/obj, please see:

    I don't think that's helpful. I know why it exists.

    FWIW: I've tried removing the src/obj directory from git and it still builds, the build script creates the src/obj directory in the build directory. It doesn't need to exist in the git repository.

  18. MarcoFalke deleted the branch on Aug 14, 2019
  19. MarcoFalke commented at 12:51 PM on August 14, 2019: member

    I don't think that's helpful. I know why it exists.

    Ah sorry. I meant to say that removing that folder should be done as part of the pull request that fixes #16588

  20. PastaPastaPasta referenced this in commit 2c5a792030 on Jun 27, 2021
  21. PastaPastaPasta referenced this in commit 7e6e324e53 on Jun 28, 2021
  22. PastaPastaPasta referenced this in commit b34c3807e4 on Jun 29, 2021
  23. PastaPastaPasta referenced this in commit 133420bd46 on Jul 1, 2021
  24. PastaPastaPasta referenced this in commit c39035072e on Jul 1, 2021
  25. PastaPastaPasta referenced this in commit 439b59c379 on Jul 12, 2021
  26. DrahtBot locked this on Dec 16, 2021
Contributors
MarcoFalkeemilenglerhebastoDrahtBotfanquakelaanwj
Labels
Build system
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 06:14 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me