doc: Fix typos in COPYRIGHT #16615

pull GChuf wants to merge 1 commits into bitcoin:master from GChuf:patch-1 changing 1 files +3 −4
  1. GChuf commented at 5:28 pm on August 14, 2019: contributor
    Fixed a couple of typos
  2. doc: Fix typos in COPYRIGHT
    Fixed a couple of typos
    36f7697cf6
  3. fanquake added the label Docs on Aug 14, 2019
  4. in contrib/debian/copyright:75 in 36f7697cf6
    71@@ -72,7 +72,6 @@ Files: src/qt/res/icons/tx_mined.png
    72        src/qt/res/src/hd_enabled.svg
    73 Copyright: Jonas Schnelli
    74 License: Expat
    75-Comment:
    


    MarcoFalke commented at 5:31 pm on August 14, 2019:
    This looks like a syntax change on the file format and not a typo?

    GChuf commented at 5:43 pm on August 14, 2019:
    There is no typo here, just a deleted line because there was no actual comment there.

    MarcoFalke commented at 6:10 pm on August 14, 2019:
    Phrased differently: Can debian still parse the file, when this field is missing? Why was it added in the first place?

    GChuf commented at 6:19 pm on August 14, 2019:
    Oh - looking at the file you can see that comments aren’t added every time. So I just assumed it’s safe to delete this line. p.s. I think adding it without any actual comment was a mistake

    MarcoFalke commented at 6:22 pm on August 14, 2019:
    ok, fine
  5. MarcoFalke commented at 5:32 pm on August 14, 2019: member
    ACK. Correct name is indeed “Stephen Hutchings”
  6. MarcoFalke added this to the milestone 0.18.2 on Aug 14, 2019
  7. MarcoFalke added the label Needs backport on Aug 14, 2019
  8. hebasto commented at 5:52 pm on August 14, 2019: member

    Correct name is indeed “Stephen Hutchings”

    Has he an account on the GutHub?

  9. laanwj commented at 5:56 pm on August 14, 2019: member

    ACK. Correct name is indeed “Stephen Hutchings”

    I was looking for conclusive source on this but couldn’t find it

  10. emilengler commented at 6:11 pm on August 14, 2019: contributor
    Concept ACK
  11. DrahtBot commented at 7:15 pm on August 14, 2019: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #16612 (qt: Remove menu icons by laanwj)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  12. promag commented at 11:32 pm on August 14, 2019: member

    ACK 36f7697cf6c129cabff2a698a52115829cd0d1fb, correct name is already here:

    https://github.com/bitcoin/bitcoin/blob/f418c3379cbad8caaf3e988caf727fe62b218f8c/contrib/debian/copyright#L51

    All occurrences are now correct.

  13. fanquake approved
  14. fanquake commented at 11:56 pm on August 14, 2019: member
    ACK 36f7697cf6c129cabff2a698a52115829cd0d1fb
  15. fanquake merged this on Aug 15, 2019
  16. fanquake closed this on Aug 15, 2019

  17. fanquake referenced this in commit 8516285d2e on Aug 15, 2019
  18. fanquake referenced this in commit 70ef5e2f45 on Aug 15, 2019
  19. fanquake removed the label Needs backport on Aug 15, 2019
  20. GChuf deleted the branch on Aug 16, 2019
  21. fanquake referenced this in commit aeb47e7446 on Aug 24, 2019
  22. fanquake referenced this in commit 1cc06a1b67 on Sep 23, 2019
  23. laanwj referenced this in commit 29d70264fb on Nov 25, 2019
  24. jasonbcox referenced this in commit bc053489c5 on Oct 13, 2020
  25. DrahtBot locked this on Dec 16, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 15:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me