build: echo property tests status during build #16622

pull jonatack wants to merge 1 commits into bitcoin:master from jonatack:property-tests-autoconf-improvements changing 1 files +3 −2

jonatack commented at 3:38 PM on August 15, 2019: member
Enable users to see if the prop tests are enabled during the build. This can be particularly helpful as property-based tests are silently auto-enabled by default if librapidcheck is found.

Sample build output:
```
Options used to compile and link:
  with wallet   = yes
  with gui / qt = yes
    with bip70  = yes
    with qr     = yes
  with zmq      = yes
  with test     = yes
    with prop   = yes                  <--- new
    with fuzz   = no
  with bench    = no
```
MarcoFalke renamed this:
~~autoconf: property tests status and options~~
build: property tests status and options
on Aug 15, 2019
DrahtBot added the label Build system on Aug 15, 2019
emilengler commented at 5:27 PM on August 15, 2019: contributor

Concept ACK bdefd5c8dc266024996d332c8c8284040b6a848e
emilengler commented at 5:29 PM on August 15, 2019: contributor

@jonatack I asked for you if someone can restart travis, this happens to me quite often as well.
jonatack force-pushed on Aug 15, 2019
jonatack renamed this:
~~build: property tests status and options~~
build: echo property tests status during build
on Aug 15, 2019
jonatack commented at 11:49 PM on August 15, 2019: member

Simplified the PR. Two of the Travis builds timed out; the others are green and this commit doesn't change anything that would fail.
in configure.ac:134 in c668216341 outdated
```
 130 | @@ -131,9 +131,10 @@ AC_ARG_ENABLE(gui-tests,
 131 |      [use_gui_tests=$enableval],
 132 |      [use_gui_tests=$use_tests])
 133 |  
 134 | +# Enable RapidCheck property-based tests
```
fanquake commented at 1:21 AM on August 16, 2019:

I don't think we need the extra comment here. That string is in the arg description, and none of the other AC_ARG_WITH instances have comments.

jonatack commented at 9:48 AM on August 16, 2019:

Thanks for reviewing. I saw that L247 (AC_ARG_WITH for sanitizers) has a comment as well as some of the AC_ARG_ENABLES. That said, ARG_WITH would normally be about building with a package, not enabling features, so L247 may not be a good example to follow. I'll remove and force push.
fanquake commented at 1:23 AM on August 16, 2019: member

Concept ACK - will test shortly. If you're interested in the build system and property tests, you might also want to checkout #14694.
fanquake approved
fanquake commented at 8:01 AM on August 16, 2019: member

tACK c66821634158010419a83aac61b8da2a8c744d4c - with the extra comment removed.

build: echo prop tests status during build

Enable users to see if the prop tests are enabled during the build. This can be particularly helpful as property-based tests are silently auto-enabled by default if librapidcheck is found.

Minor fixes to the docs and help grammar for this option.

a6c1fc3cd9

jonatack force-pushed on Aug 16, 2019
jonatack commented at 9:59 AM on August 16, 2019: member

Thanks @fanquake for testing, and also for suggesting having a look at #14694 which addresses an issue I've been seeing. Extra comment removed.
fanquake approved
fanquake commented at 10:22 AM on August 16, 2019: member

ACK a6c1fc3cd96e68d00b747ee91ea00dd66cca60e0 - Thanks. Tested ./configure with and without rapidcheck available.
fanquake referenced this in commit 1124be6111 on Aug 17, 2019
fanquake merged this on Aug 17, 2019
fanquake closed this on Aug 17, 2019
jonatack deleted the branch on Aug 17, 2019
deadalnix referenced this in commit f9d5b98ef5 on Feb 27, 2020
deadalnix referenced this in commit 254e3daef8 on Feb 28, 2020
ftrader referenced this in commit 9613af3b3e on May 19, 2020
DrahtBot locked this on Dec 16, 2021

Contributors

Labels