doc: Refer in rpcbind doc to the manpage #16634

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:1908-docManPage changing 1 files +2 −2

MarcoFalke commented at 2:53 PM on August 16, 2019: member
The help was outdated, so refer to the updated manpage instead.
- closes #14740
- closes #9272
doc: Refer in rpcbind doc to the manpage fa0119af22
fanquake added the label Docs on Aug 16, 2019
emilengler commented at 3:34 PM on August 16, 2019: contributor

Concept ACK fa0119a
DrahtBot commented at 7:02 PM on August 16, 2019: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #14740 (docs: Update rpcbind doc to match the manpage by sp4ke)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
fanquake approved
fanquake commented at 1:12 AM on August 19, 2019: member

ACK fa0119af226255ce1e0e573a575ab37539ff8693

in share/examples/bitcoin.conf:74 in fa0119af22

  69 | @@ -70,8 +70,8 @@
  70 |  # server=1 tells Bitcoin-Qt and bitcoind to accept JSON-RPC commands
  71 |  #server=0
  72 |  
  73 | -# Bind to given address to listen for JSON-RPC connections. Use [host]:port notation for IPv6.
  74 | -# This option can be specified multiple times (default: bind to all interfaces)
  75 | +# Bind to given address to listen for JSON-RPC connections.
  76 | +# Refer to the manpage or bitcoind -help for further details.

laanwj commented at 9:11 AM on August 19, 2019:

This is true for all options, really, I've sometimes wondered if we shouldn't generate the example configuration somehow (do people prefer this inline style to manpages?) instead of having a separate place with options documentation here.

laanwj commented at 9:14 AM on August 19, 2019: member

ACK fa0119af226255ce1e0e573a575ab37539ff8693

Concept ACK fa0119a

I don't understand, why would you concept ACK a one-line documentation change instead of just ACKing?
laanwj referenced this in commit 91ed1b3e06 on Aug 19, 2019
laanwj merged this on Aug 19, 2019
laanwj closed this on Aug 19, 2019
MarcoFalke deleted the branch on Aug 19, 2019
sidhujag referenced this in commit 74f4e6d259 on Aug 19, 2019
PastaPastaPasta referenced this in commit f465bec708 on Jun 27, 2021
PastaPastaPasta referenced this in commit dcaabc5862 on Jun 28, 2021
PastaPastaPasta referenced this in commit 0df3e73a1e on Jun 29, 2021
PastaPastaPasta referenced this in commit be419b4062 on Jul 1, 2021
PastaPastaPasta referenced this in commit cf19d789c2 on Jul 1, 2021
PastaPastaPasta referenced this in commit 91cc5488af on Jul 12, 2021
DrahtBot locked this on Dec 16, 2021

Contributors

Labels

Linked (view graph)

#9272 Default behavior of binding to all interfaces for RPC server not working #14740 docs: Update rpcbind doc to match the manpage

doc: Refer in rpcbind doc to the manpage #16634

Conflicts