[QT] Optimize spinner #16636

pull GChuf wants to merge 1 commits into bitcoin:master from GChuf:mv0 changing 37 files +0 −0

GChuf commented at 3:46 PM on August 16, 2019: contributor

Use 48px spinner as source Optimize files with crushing and png indexing File sizes reduces by ~85%
DrahtBot added the label GUI on Aug 16, 2019
o 098a7098c8
MarcoFalke commented at 4:49 PM on August 16, 2019: member

bitcoin-qt is already 34M, I don't think 35kB matter much
promag commented at 4:56 PM on August 16, 2019: member

Not worth it IMO.
GChuf commented at 5:09 PM on August 16, 2019: contributor

Of course, ~70kB less hardly matters but i don't see any reason why not to do it
MarcoFalke commented at 5:19 PM on August 16, 2019: member

The reason not to do it is that git can't compress binary files, and has to keep both versions. So reducing the size will slow down git clone
MarcoFalke commented at 5:20 PM on August 16, 2019: member

Another reason to not do it is that this needs a lot of testing (mac, wayland, x11, windows) x (low dpi, high dpi) x (before, after). This test matrix has 16 values
GChuf commented at 5:44 PM on August 16, 2019: contributor

I don't understand the part about compression. Can you elaborate? If I understand, git compresses data before a "git clone" downloads the data. If binary files can't be compressed, isn't it best for the binary files to be as small as possible?
MarcoFalke commented at 6:55 PM on August 16, 2019: member

isn't it best for the binary files to be as small as possible?

Yes, but git keeps the history of all files, so once it is in git there is no way to get it out or compress it.
fanquake commented at 1:26 AM on August 17, 2019: member

Thanks, however I agree with the @MarcoFalke, and this isn't mergeable as is, because you haven't used a proper commit message.
fanquake closed this on Aug 17, 2019
GChuf commented at 12:08 PM on August 17, 2019: contributor

Thanks for explanations @MarcoFalke
GChuf deleted the branch on Aug 26, 2019
DrahtBot locked this on Dec 16, 2021

Contributors

Labels