[0.17] Release preparations for 0.17.2 #16638

pull fanquake wants to merge 4 commits into bitcoin:0.17 from fanquake:0-17-2-release-prep changing 92 files +31845 −12329
  1. fanquake commented at 6:32 AM on August 17, 2019: member

    Initial preparations for a 0.17.2 release. Needs a look over by laanwj (especially translations). Also need to check that everyone that should be included in the release notes has been included.

    #15445 is the last open 0.17.2 milestone tagged PR. I'm not sure that it's a requirement though.

  2. build: bump version to 0.17.2 b4472f502c
  3. fanquake added this to the milestone 0.17.2 on Aug 17, 2019
  4. fanquake requested review from laanwj on Aug 17, 2019
  5. DrahtBot added the label Build system on Aug 17, 2019
  6. DrahtBot added the label Docs on Aug 17, 2019
  7. DrahtBot added the label GUI on Aug 17, 2019
  8. Sjors commented at 12:14 PM on August 17, 2019: member

    If possible, I'd like to include #16639

  9. laanwj commented at 10:40 AM on August 19, 2019: member

    Concept ACK, haven't checked the translation changes in detail but looks good to me on first glance

  10. in doc/man/bitcoin-qt.1:280 in c2351b379d outdated
     273 | @@ -274,10 +274,6 @@ Tor control port to use if onion listening enabled (default:
     274 |  .IP
     275 |  Tor control port password (default: empty)
     276 |  .HP
     277 | -\fB\-upnp\fR
     278 | -.IP
     279 | -Use UPnP to map the listening port (default: 0)
     280 | -.HP
    


    MarcoFalke commented at 12:30 PM on August 19, 2019:

    why is this removed?


    fanquake commented at 12:18 AM on August 20, 2019:

    Thanks, that removal was accidental, as miniupnpc wasn't available when i compiled the 0.17.2 binaries. Fixed up now.

  11. doc: update manpages for 0.17.2 c56c9ad721
  12. fanquake force-pushed on Aug 20, 2019
  13. GChuf commented at 1:03 PM on August 21, 2019: contributor

    Translations for 0.17 cleaned and updated on transifex. Be advised, some translations were merged. There were also some translations which were just duplicates and didn't add anything when merging them. The result is less language files, which are in turn more complete.

    p.s. I'd still like to further tidy up the translation on transifex, but i'm waiting for laanwj's answer. It's a mess with duplicates everywhere, and translations for locales instead of languages in some cases. Cleaning up further for 0.17 and 0.18 would only make a bigger mess on transifex since I can't move 0.14, 0.15 and 0.16 versions around.

  14. qt: 0.17.2 translation update 6b42df88ce
  15. doc: update release notes for 0.17.2 0bd04c5dd4
  16. fanquake force-pushed on Aug 27, 2019
  17. fanquake commented at 12:40 AM on August 27, 2019: member

    I've updated this to pull the latest Transifex changes for 0.17.

    Cleaning up further for 0.17 and 0.18 would only make a bigger mess on transifex since I can't move 0.14, 0.15 and 0.16 versions around.

    I'd suggest just concentrating on the upcoming 0.19 release. "Cleaning up" anything more for 0.17 and even 0.18 is going to be low impact

  18. GChuf commented at 10:51 AM on August 27, 2019: contributor

    "Cleaning up" anything more for 0.17 and even 0.18 is going to be low impact

    I'm well aware of that, I wasn't going to clean the older translations, just move some of them from locales to languages - since I can't do that, moving languages around can make a mess on transifex. Languages which appeared to be complete (100% translated in every branch) would then be only ~80% translated, even though 017x and 018x would be at 100%. I'd rather move all translations together, so that the older translations stay on transifex as examples.

    ///

    I took a quick look at the translations, it seems that the bitcoin_si.ts is wrong - the translations are in another language. I already fixed it on transifex. Please either remove the file or pull the translations from transifex again if it's not too much work.

  19. laanwj commented at 9:41 AM on August 29, 2019: member

    since I can't move 0.14, 0.15 and 0.16 versions around.

    Please don't spend time on those versions, their translations will never end up in a release anymore. Only the last two major releases have active translation, and I agree with @fanquake that it only makes sense to focus on the latest release (now 0.18, translations will open for 0.19 in a few days) for major changes.

  20. laanwj approved
  21. laanwj commented at 9:58 AM on August 29, 2019: member

    ACK 0bd04c5dd49e1ebc1ffd1db1cc8c42345924865d

  22. laanwj referenced this in commit 01a1537fe0 on Aug 29, 2019
  23. laanwj merged this on Aug 29, 2019
  24. laanwj closed this on Aug 29, 2019

  25. laanwj commented at 9:59 AM on August 29, 2019: member

    but i'm waiting for laanwj's answer

    Sorry, answer to what are you waiting for?

  26. GChuf commented at 11:23 AM on August 29, 2019: contributor

    @laanwj sorry if I wasn't clear enough. I'm not spending time on 0.14 - 0.16. I'd just like to tidy up translations on transifex and move translations from locales to languages ((cs_CZ) to (cs) for example), because we don't need a locale for czech language. To do this in a clean way, I'd also have to move 0.14-0.16 translations around (or just delete them), which I can't at the moment.

    I was asking you for permissions/credentials to do that, but I can't exactly remember when and where. I've also sent you a message on transifex a while ago, asking for coordinator/reviewer role for slovenian language (si) and (si_SI) (account name gasper.cefarin).

    I've already done a lot of cleaning and some reorganizing on traqnsifex- you'll see the bump in edited/translated words on transifex dashboard for August.

  27. laanwj commented at 11:29 AM on August 29, 2019: member

    @gchuf OK, I don't really have control over the transifex organization to deal out credentials AFAIK, apart from making people "maintainer". The person who created it, "seone" seems to have gone MIA, maybe @luke-jr knows more. I do not have access to the "team" pages, for example.

    Maybe for the next version it'd make sense to move to a new transifex organization.

    Edit: I should be able to add/delete resources though, so will try to delete those old versions.

  28. laanwj commented at 11:41 AM on August 29, 2019: member

    I've managed to remove the 0.14-0.16 resources. As for the other questions, see #16754.

  29. fanquake deleted the branch on Jan 22, 2020
  30. DrahtBot locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-15 15:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me