[0.17] abort when attempting to fund a transaction above -maxtxfee #16639

1. 
   Sjors commented at 12:14 pm on August 17, 2019: member

   Backport #16257.

   Cherry-picked from the 0.18 backport in #16414, but without the [wip] messages and without the last commit (which adds a test in a file that didn’t exist in 0.17).

2. DrahtBot added the label Docs on Aug 17, 2019
3. DrahtBot added the label Tests on Aug 17, 2019
4. DrahtBot added the label TX fees and policy on Aug 17, 2019
5. DrahtBot added the label Wallet on Aug 17, 2019
6. fanquake added the label Backport on Aug 17, 2019
7. fanquake added this to the milestone 0.17.2 on Aug 17, 2019
8. fanquake removed the label Docs on Aug 17, 2019
9. fanquake removed the label TX fees and policy on Aug 17, 2019
10. 
    promag commented at 11:56 pm on August 18, 2019: member

    Concept ACK.
11. [wallet] abort when attempting to fund a transaction above maxtxfee

    FundTransaction calls GetMinimumFee which, when the fee rate is absurdly high, quietly reduced the fee to -maxtxfee. Becaue an absurdly high fee rate is usually the result of a fat finger, aborting seems safer behavior.
    
    Github-Pull: #16257
    Rebased-From: 806b0052c3b45415862f74f20ba5f389e5b673de

    e9adb96f88
12. Sjors force-pushed on Aug 19, 2019
13. wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransaction

    Github-Pull: #16322
    Rebased-From: 5c1b9714cb0a13be28324f91f4ec9ca66a1de8c7

    0e7c7465bf
14. Sjors force-pushed on Aug 19, 2019
15. 
    Sjors commented at 2:19 pm on August 19, 2019: member

    Manually added Github-Pull: and Rebased-From fields.
16. 
    laanwj commented at 10:47 am on September 12, 2019: member

    ACK 0e7c7465bf2b9911da094d9790480f94e158f9a5
17. laanwj referenced this in commit 1659b9b099 on Sep 12, 2019
18. laanwj merged this on Sep 12, 2019
19. laanwj closed this on Sep 12, 2019

    ---

20. 
    Sjors commented at 3:38 pm on September 12, 2019: member

    Thanks. Note that 0.18 backport is still open in https://github.com/bitcoin/bitcoin/pull/16414
21. fanquake referenced this in commit cad069157a on Sep 13, 2019
22. fanquake referenced this in commit fb9baded74 on Sep 13, 2019
23. laanwj referenced this in commit e149cbe5c7 on Sep 13, 2019
24. DrahtBot locked this on Dec 16, 2021

Contributors
Sjors promag laanwj

Labels
Wallet Tests Backport

Milestone
0.17.2