build: latest rapidcheck, update configuration #16654

1. 
   jonatack commented at 11:50 am on August 19, 2019: member

   • update RapidCheck to the latest commit on master
   • install only the extras needed by Bitcoin Core, e.g. ENABLE_BOOST_TEST instead of INSTALL_ALL_EXTRAS
   • remove cmake warning by providing -B arg:

     0CMake Warning:
     1No source or binary directory provided.  Both will be assumed to be the
     2same as the current working directory, but note that this warning will
     3become a fatal error in future CMake releases.
     

   Tested with cd depends && make RAPIDCHECK=1 on Linux Debian.

2. fanquake added the label Build system on Aug 19, 2019
3. in depends/packages/rapidcheck.mk:5 in d1ef69d111 outdated

   0@@ -1,11 +1,11 @@
   1 package=rapidcheck
   2-$(package)_version=3eb9b4ff69f4ff2d9932e8f852c2b2a61d7c20d3
   3+$(package)_version=d9482c683429fe79122e3dcab14c9655874aeb8e
   4 $(package)_download_path=https://github.com/emil-e/rapidcheck/archive
   5 $(package)_file_name=$($(package)_version).tar.gz
   6 $(package)_sha256_hash=5fbf82755c9a647127e62563be079448ff8b1db9ca80a52a673dd9a88fdb714b
   

   ---

   ---

   

   fanquake commented at 3:26 am on August 20, 2019:

   You’ll need to update the sha256_hash for this to work.

   0shasum -a 256 /Users/michael/Downloads/rapidcheck-d9482c683429fe79122e3dcab14c9655874aeb8e.tar.gz 
   1b9ee8955b175fd3c0757ebd887bb075541761af08b0c28391b7c6c0685351f6b  /Users/michael/Downloads/rapidcheck-d9482c683429fe79122e3dcab14c9655874aeb8e.tar.gz
   

   ---

   

   jonatack commented at 1:35 pm on August 21, 2019:

   Thank you. Verified the hash on my end and updated.
4. in depends/packages/rapidcheck.mk:8 in d1ef69d111 outdated

    5 $(package)_file_name=$($(package)_version).tar.gz
    6 $(package)_sha256_hash=5fbf82755c9a647127e62563be079448ff8b1db9ca80a52a673dd9a88fdb714b
    7 
    8 define $(package)_config_cmds
    9-  cmake -DCMAKE_INSTALL_PREFIX=$($(package)_staging_dir)$(host_prefix) -DCMAKE_POSITION_INDEPENDENT_CODE:BOOL=true -DRC_INSTALL_ALL_EXTRAS=ON
   10+  cmake -DCMAKE_INSTALL_PREFIX=$($(package)_staging_dir)$(host_prefix) -DCMAKE_POSITION_INDEPENDENT_CODE:BOOL=true -DRC_ENABLE_BOOST_TEST=ON
   

   ---

   ---

   

   fanquake commented at 3:28 am on August 20, 2019:

   ACK DRC_ENABLE_BOOST_TEST. This seems better than DRC_INSTALL_ALL_EXTRAS.
5. 
   fanquake commented at 3:33 am on August 20, 2019: member

   Concept ACK

   Did a depends build after fixing up the SHA hash. Compiling works and property tests run ok.

   What do you mean by:

   because I’d like to have the Makefile autobuild RapidCheck

6. build: update RapidCheck Makefile

   - update RapidCheck to latest commit on master
   - install only the extras needed by Bitcoin Core
   - update shasum hash
   - remove CMake warning

   f7220e85fd
7. jonatack force-pushed on Aug 21, 2019
8. jonatack renamed this:
   [WIP] build: update RapidCheck Makefile
   build: update RapidCheck Makefile
   on Aug 21, 2019
9. jonatack force-pushed on Aug 21, 2019
10. 
    jonatack commented at 1:41 pm on August 21, 2019: member

    What do you mean by:

    because I’d like to have the Makefile autobuild RapidCheck

    Thank you for reviewing! I wanted RapidCheck to build with RAPIDCHECK=1 make… then realized I just needed to cd into the /depends dir first. I also tried to get rid of the CMake warnings about the future fatal missing build dir by adding the -B argument. Updated the PR title and description.

11. jonatack force-pushed on Aug 21, 2019
12. fanquake renamed this:
    build: update RapidCheck Makefile
    build: latest rapidcheck, update configuration
    on Aug 22, 2019
13. fanquake approved
14. 
    fanquake commented at 2:00 am on August 22, 2019: member

    ACK f7220e85fd7df95ca98c7b7b262b30751f70da2f - Tested building using depends. ENABLE_BOOST_TEST instead of INSTALL_ALL_EXTRAS seems fine.
15. fanquake referenced this in commit 43eaf76e02 on Aug 23, 2019
16. fanquake merged this on Aug 23, 2019
17. fanquake closed this on Aug 23, 2019

    ---

18. jonatack deleted the branch on Aug 23, 2019
19. fanquake referenced this in commit 442a9c6477 on Aug 23, 2019
20. deadalnix referenced this in commit 6f7a725639 on Feb 27, 2020
21. ftrader referenced this in commit a6c6a799f3 on May 19, 2020
22. MarcoFalke locked this on Dec 16, 2021

Contributors
jonatack fanquake

Labels
Build system