scripts: move update-translations.py to maintainer-tools repo #16665

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:move_maintainer_scripts changing 3 files +2 −229
  1. fanquake commented at 3:16 AM on August 20, 2019: member

    As mentioned in #16644, move the update-translations.py script out of the bitcoin/bitcoin repo. This script is run infrequently by maintainers, and aside from #16644, doesn't see many changes. If it is going to be changed, it probably shouldn't consume review bandwidth in bitcoin/bitcoin anyways.

    PR adding the script to the maintainer-tools repo: https://github.com/bitcoin-core/bitcoin-maintainer-tools/pull/31

    Could also move some other scripts, such as gen-manpages.sh.

  2. scripts: move update-translations.py to maintainer-tools repo 3d50fe2c1f
  3. fanquake added the label Scripts and tools on Aug 20, 2019
  4. DrahtBot commented at 4:34 AM on August 20, 2019: member

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #16644 (scripts: attempt to fix some translations in update-translations.py by GChuf)
    • #16539 (wallet: lower -txmaxfee default from 0.1 to 0.01 BTC by Sjors)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  5. GChuf commented at 9:27 AM on August 20, 2019: contributor

    Why not include the other scripts in devtools as well then? They might get updated in the future as well.

  6. emilengler commented at 2:33 PM on August 20, 2019: contributor

    Could you update the link to the script in the maintainers repo once the PR is being merged?

  7. fanquake commented at 1:54 AM on August 21, 2019: member

    Why not include the other scripts in devtools as well then? They might get updated in the future as well.

    I might update this to include gen-manpags.sh. I don't think everything in devtools/ needs to be moved into the maintainer repo, because they aren't all maintainer tools.

  8. laanwj commented at 11:50 AM on August 24, 2019: member

    ACK 3d50fe2c1fb566501257fc16d4606e06f518a0bb this was merged to maintainer-tools n bitcoin-core/bitcoin-maintainer-tools#31

    Why not include the other scripts in devtools as well then? They might get updated in the future as well.

    Maybe. Let's discuss these on a case by case basis.

  9. fanquake referenced this in commit db67101c74 on Aug 25, 2019
  10. fanquake merged this on Aug 25, 2019
  11. fanquake closed this on Aug 25, 2019

  12. fanquake deleted the branch on Aug 25, 2019
  13. sidhujag referenced this in commit 2ae55d4ae7 on Aug 25, 2019
  14. DrahtBot locked this on Dec 16, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-26 06:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me