build: remove mingw linker workaround from win gitian descriptor #16667

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:remove_mingw_linker_workaround changing 1 files +4 −12
  1. fanquake commented at 7:51 am on August 20, 2019: member

    This workaround was added as part of the switch to gitian building using Ubuntu 14.04 (#6900). However, it should no longer be required, as we have switched to Bionic (#13171) and that has a far newer version of binutils.

    Original discussion: #6900 binutils patch: https://sourceware.org/bugzilla/show_bug.cgi?id=16192

  2. fanquake added the label Build system on Aug 20, 2019
  3. fanquake added the label Needs gitian build on Aug 20, 2019
  4. fanquake requested review from laanwj on Aug 20, 2019
  5. DrahtBot removed the label Needs gitian build on Aug 21, 2019
  6. MarcoFalke commented at 11:14 am on August 21, 2019: member

    Fails with

      0Options used to compile and link:
  1  with wallet   = yes
  2  with gui / qt = yes
  3    with bip70  = yes
  4    with qr     = yes
  5  with zmq      = yes
  6  with test     = yes
  7    with prop   = no
  8    with fuzz   = no
  9  with bench    = no
 10  with upnp     = yes
 11  use asm       = yes
 12  sanitizers    = 
 13  debug enabled = no
 14  gprof enabled = no
 15  werror        = no
 16
 17  target os     = windows
 18  build os      = 
 19
 20  CC            = x86_64-w64-mingw32-gcc
 21  CFLAGS        = -pipe -O2 -O2 -g
 22  CPPFLAGS      =   -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -I/home/ubuntu/build/bitcoin/depends/x86_64-w64-mingw32/share/../include/  -DHAVE_BUILD_INFO -D__STDC_FORMAT_MACROS -D_MT -DWIN32 -D_WINDOWS -DBOOST_THREAD_USE_LIB -D_WIN32_WINNT=0x0601 -D_FILE_OFFSET_BITS=64
 23  CXX           = x86_64-w64-mingw32-g++ -std=c++11
 24  CXXFLAGS      =   -fstack-reuse=none -Wstack-protector -fstack-protector-all     -pipe -O2 -O2 -g -fvisibility=hidden
 25  LDFLAGS       = -pthread  -Wl,--dynamicbase -Wl,--nxcompat -Wl,--high-entropy-va -pie  -L/home/ubuntu/build/bitcoin/depends/x86_64-w64-mingw32/share/../lib 
 26  ARFLAGS       = cr
 27
 28+ make -j1
 29Making all in src
 30make[1]: Entering directory '/home/ubuntu/build/bitcoin/distsrc-x86_64-w64-mingw32/src'
 31make[2]: Entering directory '/home/ubuntu/build/bitcoin/distsrc-x86_64-w64-mingw32/src'
 32  CXX      support/libbitcoinconsensus_la-cleanse.lo
 33  CXX      crypto/libbitcoinconsensus_la-aes.lo
 34  CXX      crypto/libbitcoinconsensus_la-chacha_poly_aead.lo
 35  CXX      crypto/libbitcoinconsensus_la-chacha20.lo
 36  CXX      crypto/libbitcoinconsensus_la-hkdf_sha256_32.lo
 37  CXX      crypto/libbitcoinconsensus_la-hmac_sha256.lo
 38  CXX      crypto/libbitcoinconsensus_la-hmac_sha512.lo
 39  CXX      crypto/libbitcoinconsensus_la-poly1305.lo
 40  CXX      crypto/libbitcoinconsensus_la-ripemd160.lo
 41  CXX      crypto/libbitcoinconsensus_la-sha1.lo
 42  CXX      crypto/libbitcoinconsensus_la-sha256.lo
 43  CXX      crypto/libbitcoinconsensus_la-sha512.lo
 44  CXX      crypto/libbitcoinconsensus_la-siphash.lo
 45  CXX      crypto/libbitcoinconsensus_la-sha256_sse4.lo
 46  CXX      libbitcoinconsensus_la-arith_uint256.lo
 47  CXX      consensus/libbitcoinconsensus_la-merkle.lo
 48  CXX      consensus/libbitcoinconsensus_la-tx_check.lo
 49  CXX      libbitcoinconsensus_la-hash.lo
 50  CXX      primitives/libbitcoinconsensus_la-block.lo
 51  CXX      primitives/libbitcoinconsensus_la-transaction.lo
 52  CXX      libbitcoinconsensus_la-pubkey.lo
 53  CXX      script/libbitcoinconsensus_la-bitcoinconsensus.lo
 54  CXX      script/libbitcoinconsensus_la-interpreter.lo
 55  CXX      script/libbitcoinconsensus_la-script.lo
 56  CXX      script/libbitcoinconsensus_la-script_error.lo
 57  CXX      libbitcoinconsensus_la-uint256.lo
 58  CXX      util/libbitcoinconsensus_la-strencodings.lo
 59make[3]: Entering directory '/home/ubuntu/build/bitcoin/distsrc-x86_64-w64-mingw32/src/secp256k1'
 60gcc -I. -g -O2 -Wall -Wextra -Wno-unused-function -c src/gen_context.c -o gen_context.o
 61gcc -g -O2 -Wall -Wextra -Wno-unused-function  gen_context.o -o gen_context
 62./gen_context
 63  CC       src/libsecp256k1_la-secp256k1.lo
 64  CCLD     libsecp256k1.la
 65libtool: warning: undefined symbols not allowed in x86_64-w64-mingw32 shared libraries; building static only
 66/usr/bin/x86_64-w64-mingw32-ar: `u' modifier ignored since `D' is the default (see `U')
 67make[3]: Leaving directory '/home/ubuntu/build/bitcoin/distsrc-x86_64-w64-mingw32/src/secp256k1'
 68  CXXLD    libbitcoinconsensus.la
 69/usr/bin/x86_64-w64-mingw32-ar: `u' modifier ignored since `D' is the default (see `U')
 70  CXX      bitcoind-bitcoind.o
 71In file included from ./util/system.h:21:0,
 72                 from ./init.h:11,
 73                 from bitcoind.cpp:14:
 74./logging.h:63:22: error: ‘mutex’ in namespace ‘std’ does not name a type
 75         mutable std::mutex m_cs;                   // Can not use Mutex from sync.h because in debug mode it would cause a deadlock when a potential deadlock was detected
 76                      ^~~~~
 77In file included from ./util/system.h:21:0,
 78                 from ./init.h:11,
 79                 from bitcoind.cpp:14:
 80./logging.h: In member function ‘bool BCLog::Logger::Enabled() const’:
 81./logging.h:97:34: error: ‘mutex’ is not a member of ‘std’
 82             std::lock_guard<std::mutex> scoped_lock(m_cs);
 83                                  ^~~~~
 84./logging.h:97:34: error: ‘mutex’ is not a member of ‘std’
 85./logging.h:97:39: error: template argument 1 is invalid
 86             std::lock_guard<std::mutex> scoped_lock(m_cs);
 87                                       ^
 88./logging.h:97:53: error: ‘m_cs’ was not declared in this scope
 89             std::lock_guard<std::mutex> scoped_lock(m_cs);
 90                                                     ^~~~
 91In file included from ./util/system.h:22:0,
 92                 from ./init.h:11,
 93                 from bitcoind.cpp:14:
 94./sync.h: At global scope:
 95./sync.h:107:44: error: ‘recursive_mutex’ is not a member of ‘std’
 96 using RecursiveMutex = AnnotatedMixin<std::recursive_mutex>;
 97                                            ^~~~~~~~~~~~~~~
 98./sync.h:107:44: error: ‘recursive_mutex’ is not a member of ‘std’
 99./sync.h:107:59: error: template argument 1 is invalid
100 using RecursiveMutex = AnnotatedMixin<std::recursive_mutex>;
101                                                           ^
102./sync.h:108:29: error: ‘recursive_mutex’ is not a member of ‘std’
103 typedef AnnotatedMixin<std::recursive_mutex> CCriticalSection;
104                             ^~~~~~~~~~~~~~~
105./sync.h:108:29: error: ‘recursive_mutex’ is not a member of ‘std’
106./sync.h:108:44: error: template argument 1 is invalid
107 typedef AnnotatedMixin<std::recursive_mutex> CCriticalSection;
108                                            ^
109./sync.h:111:29: error: ‘mutex’ is not a member of ‘std’
110 typedef AnnotatedMixin<std::mutex> Mutex;
111                             ^~~~~
112./sync.h:111:29: error: ‘mutex’ is not a member of ‘std’
113./sync.h:111:34: error: template argument 1 is invalid
114 typedef AnnotatedMixin<std::mutex> Mutex;
115                                  ^
116./sync.h:214:10: error: ‘condition_variable’ in namespace ‘std’ does not name a type
117     std::condition_variable condition;
118          ^~~~~~~~~~~~~~~~~~
119./sync.h:215:10: error: ‘mutex’ in namespace ‘std’ does not name a type
120     std::mutex mutex;
121          ^~~~~
122./sync.h: In member function ‘void CSemaphore::wait()’:
123./sync.h:223:31: error: ‘mutex’ is not a member of ‘std’
124         std::unique_lock<std::mutex> lock(mutex);
125                               ^~~~~
126./sync.h:223:31: error: ‘mutex’ is not a member of ‘std’
127./sync.h:223:36: error: template argument 1 is invalid
128         std::unique_lock<std::mutex> lock(mutex);
129                                    ^
130./sync.h:223:43: error: ‘mutex’ was not declared in this scope
131         std::unique_lock<std::mutex> lock(mutex);
132                                           ^~~~~
133./sync.h:223:43: note: suggested alternative: ‘Mutex’
134         std::unique_lock<std::mutex> lock(mutex);
135                                           ^~~~~
136                                           Mutex
137./sync.h:224:9: error: ‘condition’ was not declared in this scope
138         condition.wait(lock, [&]() { return value >= 1; });
139         ^~~~~~~~~
140./sync.h: In member function ‘bool CSemaphore::try_wait()’:
141./sync.h:230:30: error: ‘mutex’ is not a member of ‘std’
142         std::lock_guard<std::mutex> lock(mutex);
143                              ^~~~~
144./sync.h:230:30: error: ‘mutex’ is not a member of ‘std’
145./sync.h:230:35: error: template argument 1 is invalid
146         std::lock_guard<std::mutex> lock(mutex);
147                                   ^
148./sync.h:230:42: error: ‘mutex’ was not declared in this scope
149         std::lock_guard<std::mutex> lock(mutex);
150                                          ^~~~~
151./sync.h:230:42: note: suggested alternative: ‘Mutex’
152         std::lock_guard<std::mutex> lock(mutex);
153                                          ^~~~~
154                                          Mutex
155./sync.h: In member function ‘void CSemaphore::post()’:
156./sync.h:240:34: error: ‘mutex’ is not a member of ‘std’
157             std::lock_guard<std::mutex> lock(mutex);
158                                  ^~~~~
159./sync.h:240:34: error: ‘mutex’ is not a member of ‘std’
160./sync.h:240:39: error: template argument 1 is invalid
161             std::lock_guard<std::mutex> lock(mutex);
162                                       ^
163./sync.h:240:46: error: ‘mutex’ was not declared in this scope
164             std::lock_guard<std::mutex> lock(mutex);
165                                              ^~~~~
166./sync.h:240:46: note: suggested alternative: ‘Mutex’
167             std::lock_guard<std::mutex> lock(mutex);
168                                              ^~~~~
169                                              Mutex
170./sync.h:243:9: error: ‘condition’ was not declared in this scope
171         condition.notify_one();
172         ^~~~~~~~~
173./sync.h: In substitution of ‘template<class MutexArg> using DebugLock = UniqueLock<typename std::remove_reference<typename std::remove_pointer<_Tp>::type>::type> [with MutexArg = int]’:
174./util/system.h:287:9:   required from here
175./sync.h:177:113: error: ‘std::remove_reference<int>::type {aka int}’ is not a class, struct, or union type
176 using DebugLock = UniqueLock<typename std::remove_reference<typename std::remove_pointer<MutexArg>::type>::type>;
177                                                                                                                 ^
178./util/system.h: In member function ‘void ArgsManager::ClearArgs()’:
179./sync.h:182:104: error: expression list treated as compound expression in initializer [-fpermissive]
180 #define LOCK(cs) DebugLock<decltype(cs)> PASTE2(criticalblock, __COUNTER__)(cs, #cs, __FILE__, __LINE__)
181                                                                                                        ^
182./util/system.h:287:9: note: in expansion of macro ‘LOCK’
183         LOCK(cs_args);
184         ^
185Makefile:10694: recipe for target 'bitcoind-bitcoind.o' failed
186make[2]: *** [bitcoind-bitcoind.o] Error 1
187make[2]: Leaving directory '/home/ubuntu/build/bitcoin/distsrc-x86_64-w64-mingw32/src'
188Makefile:13149: recipe for target 'all-recursive' failed
189make[1]: *** [all-recursive] Error 1
190make[1]: Leaving directory '/home/ubuntu/build/bitcoin/distsrc-x86_64-w64-mingw32/src'
191Makefile:774: recipe for target 'all-recursive' failed
192make: *** [all-recursive] Error 1
  7. in contrib/gitian-descriptors/gitian-win.yml:90 in ac85e81685 outdated 
    85-        echo "${REAL} \$@" >> $WRAP_DIR/${i}/${prog}
86-        chmod +x ${WRAP_DIR}/${i}/${prog}
87-    done
88-    for prog in gcc g++; do
89-        echo '#!/usr/bin/env bash' > ${WRAP_DIR}/${i}-${prog}
90-        echo "REAL=\`which -a ${i}-${prog}-posix | grep -v ${WRAP_DIR}/${i}-${prog} | head -1\`" >> ${WRAP_DIR}/${i}-${prog}
    theuni commented at 3:50 pm on August 21, 2019:
    We still need the -posix variant for c++11 threading.
    hebasto commented at 9:01 am on October 10, 2019:

    We still need the -posix variant for c++11 threading.

    Could someone point me to a related reference and/or discussion?

  8. theuni changes_requested
  9. theuni commented at 3:50 pm on August 21, 2019: member
    Concept ACK.
  10. DrahtBot commented at 5:43 am on August 24, 2019: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    No conflicts as of last run.

  11. build: remove mingw linker workaround from win gitian descriptor 
    This workaround was added as part of the switch to gitian building using Ubuntu 14.04 (#6900).
However, it should no longer be required, as we have switched to Bionic (#13171), and that
has a far newer version of binutils.

binutils patch: https://sourceware.org/bugzilla/show_bug.cgi?id=16192
    bd3f5a90ec
  12. fanquake force-pushed on Sep 23, 2019
  13. fanquake added the label Needs gitian build on Sep 23, 2019
  14. DrahtBot commented at 4:29 pm on September 23, 2019: member

    Gitian builds for commit 13377b7a695c2fc774946cfd6a9aa01dd338e13c (master):

    Gitian builds for commit 2cfaf8bbd8d0a5a42ed8c0762aff98b3ebf6f155 (master and this pull):

  15. DrahtBot removed the label Needs gitian build on Sep 23, 2019
  16. MarcoFalke deleted a comment on Sep 23, 2019
  17. dongcarl commented at 9:19 pm on September 23, 2019: member
    Performing a Gitian build on bd3f5a90ecd6de40516141b23b0861dbba0b31b6 right now if anyone wants to compare.
  18. MarcoFalke commented at 10:01 pm on September 23, 2019: member
    Eh? DrahtBot did a build on 2cfaf8b and it didn’t even start. (Or for some other reason didn’t produce a win-build.log)
  19. MarcoFalke added the label Needs gitian build on Sep 23, 2019
  20. DrahtBot removed the label Needs gitian build on Sep 24, 2019
  21. MarcoFalke commented at 2:01 pm on September 24, 2019: member
    Aw sorry :man_facepalming:. Looks like this time it worked.
  22. laanwj commented at 1:44 pm on September 25, 2019: member
    What is the status of this?
  23. MarcoFalke commented at 5:26 pm on September 25, 2019: member

    ACK bd3f5a90ecd6de40516141b23b0861dbba0b31b6

    Signature:

     0-----BEGIN PGP SIGNED MESSAGE-----
 1Hash: SHA512
 2
 3ACK bd3f5a90ecd6de40516141b23b0861dbba0b31b6
 4-----BEGIN PGP SIGNATURE-----
 5
 6iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
 7pUjb6Qv+Jda+FAxquHn1EbKNQAjfQw203BOxP7LiHD+Ot/x3yJD6OVpH6kaK25yZ
 8OPqIJnkypvXJKRxjFVsQJ+vX46scSds2XMh5newn+at4tNxxm1dsWcbnCiLbP2vw
 97TCLY51yu84/qGH45vAT4oq9VIninEm2joB2AyklkFqmbSeFutbdII6KNCQ2flzV
10kcVubISckkfH0YVWuPn226AM7/n0ngeP8jE9c5CB25ISkEOVatGDLngj9CeARH8Q
11LUjuCK0hbx0/vG9Xm6I4fDWNs5TGl0NH2jYjZUpjLoVUsm9L4s0xej8WB13QU642
12VvRX6ZSsuf1im+2FSbtgbN+h6jlXN0rEodxXZqJ0i6FB1mGtajwgH+pW6/68bEXH
135ODcGrCvcNfmjQvvGAo411cwlT2NfFOJVNpBoegmx8zPjoaf9BKW3xJXNihP0bMe
145uwm3HpZfpKrJdK7MXALfZ/HLNKdItz2JKjCi5x6uPhi0wHtjjAOThpeloPnc7o8
15zgnRDWSy
16=rcs4
17-----END PGP SIGNATURE-----

    Timestamp of file with hash 90e31459a25983012aabe70c185b6812d7ef8b09395071eab003f7376b37a810 -

  24. MarcoFalke added the label Needs gitian build on Sep 25, 2019
  25. MarcoFalke commented at 9:36 pm on September 25, 2019: member

    Ok, I am confused.

    For commit 7b2a788d911e5c3f5aeb36dba5a03827428e800b (master+this pull) it failed:

    scratch/gitian/bitcoin-binaries/7b2a788d911e5c3f5aeb36dba5a03827428e800b/win-build.log

  26. MarcoFalke commented at 9:38 pm on September 25, 2019: member
    Does anyone have any results (apart from @DrahtBot, whose results were inconclusive) @dongcarl @fanquake
  27. MarcoFalke commented at 9:53 pm on September 25, 2019: member
    Also fails for commit bd3f5a90ecd6de40516141b23b0861dbba0b31b6
  28. dongcarl commented at 9:58 pm on September 25, 2019: member

    @MarcoFalke Here are my results for bd3f5a90ecd6de40516141b23b0861dbba0b31b6

    0ef63c5ce021cf4d16b6ee148f7886ab2af50d415560dd1f7117e5f56743b72a4  bitcoin-0.18.99-win-unsigned.tar.gz
1919038118da38a28a0a4d391c0c56cd53d32d5470bed1d6984134d514cb2ae13  bitcoin-0.18.99-win64-debug.zip
24f525a8cc5852b1db4c5d98d218117f153eccc722f1bc69394dc9412c7ac417c  bitcoin-0.18.99-win64-setup-unsigned.exe
34aa2e0c4f32fcca6c557f2581aaf7578f271fe329264e090305d504223e62dcf  bitcoin-0.18.99-win64.zip
4c7d72ac57753ffda64d88760d3e4c9bba1904faec342bf64150eb992dc9a003b  src/bitcoin-0.18.99.tar.gz
504ea46d6543ac225ebbf3e5896a2779f4389d9472ec30ec785e437e88a1da548  bitcoin-core-win-0.19-res.yml
  29. MarcoFalke commented at 10:13 pm on September 25, 2019: member
    Which virtualization are you using (lxc, kvm, podman, docker, bare metal, …)?
  30. MarcoFalke commented at 10:14 pm on September 25, 2019: member
    Also, how many compile threads and is the result stable for you?
  31. dongcarl commented at 10:18 pm on September 25, 2019: member

    Here’s what I used:

    0env USE_DOCKER=1 ./bin/gbuild -j48 -m 32768 --commit bitcoin=bd3f5a90ecd6de40516141b23b0861dbba0b31b6 --url bitcoin=https://github.com/fanquake/bitcoin.git ~/src/bitcoin/fanquake/remove_mingw_linker_workaround/contrib/gitian-descriptors/gitian-win.yml

    I’ll try it again to see if result is stable!

  32. dongcarl commented at 10:38 pm on September 25, 2019: member

    Everything important seems to match except the res.yml:

    0ef63c5ce021cf4d16b6ee148f7886ab2af50d415560dd1f7117e5f56743b72a4  bitcoin-0.18.99-win-unsigned.tar.gz
1919038118da38a28a0a4d391c0c56cd53d32d5470bed1d6984134d514cb2ae13  bitcoin-0.18.99-win64-debug.zip
24f525a8cc5852b1db4c5d98d218117f153eccc722f1bc69394dc9412c7ac417c  bitcoin-0.18.99-win64-setup-unsigned.exe
34aa2e0c4f32fcca6c557f2581aaf7578f271fe329264e090305d504223e62dcf  bitcoin-0.18.99-win64.zip
4c7d72ac57753ffda64d88760d3e4c9bba1904faec342bf64150eb992dc9a003b  src/bitcoin-0.18.99.tar.gz
55fb863503148b130fe4e7b217b588840aa67f1701588068eeb76b6837b4ea545  bitcoin-core-win-0.19-res.yml
  33. MarcoFalke commented at 10:48 pm on September 25, 2019: member
    Thanks, I’ll debug some more maybe tomorrow
  34. fanquake commented at 2:03 am on September 26, 2019: member

    I just ran a build using:

    0env USE_DOCKER=1 ./bin/gbuild -j6 -m 6000 --commit bitcoin=bd3f5a90ecd6de40516141b23b0861dbba0b31b6 --url bitcoin=https://github.com/fanquake/bitcoin.git /Users/michael/github/bitcoin/contrib/gitian-descriptors/gitian-win.yml

    Results match @dongcarl except for res.yml. Can run another one this arvo to confirm.

    0Generating report
1ef63c5ce021cf4d16b6ee148f7886ab2af50d415560dd1f7117e5f56743b72a4  bitcoin-0.18.99-win-unsigned.tar.gz
2919038118da38a28a0a4d391c0c56cd53d32d5470bed1d6984134d514cb2ae13  bitcoin-0.18.99-win64-debug.zip
34f525a8cc5852b1db4c5d98d218117f153eccc722f1bc69394dc9412c7ac417c  bitcoin-0.18.99-win64-setup-unsigned.exe
44aa2e0c4f32fcca6c557f2581aaf7578f271fe329264e090305d504223e62dcf  bitcoin-0.18.99-win64.zip
5c7d72ac57753ffda64d88760d3e4c9bba1904faec342bf64150eb992dc9a003b  src/bitcoin-0.18.99.tar.gz
6f3ba7af8c756a8cb87d71ffbde2b91654eda803d7fdcbd843ff910b85ce826bd  bitcoin-core-win-0.19-res.yml
7Done.
  35. fanquake commented at 7:44 am on September 26, 2019: member

    Did another build with less cores and memory. @dongcarl looks like my res.yml isn’t changing between builds:

    0time env USE_DOCKER=1 ./bin/gbuild -j4 -m 4000 --commit bitcoin=bd3f5a90ecd6de40516141b23b0861dbba0b31b6 --url bitcoin=https://github.com/fanquake/bitcoin.git /Users/michael/github/bitcoin/contrib/gitian-descriptors/gitian-win.yml 

     0Running build script (log in var/build.log)
 1Grabbing results from target
 2Grabbing cache from target
 3Generating report
 4ef63c5ce021cf4d16b6ee148f7886ab2af50d415560dd1f7117e5f56743b72a4  bitcoin-0.18.99-win-unsigned.tar.gz
 5919038118da38a28a0a4d391c0c56cd53d32d5470bed1d6984134d514cb2ae13  bitcoin-0.18.99-win64-debug.zip
 64f525a8cc5852b1db4c5d98d218117f153eccc722f1bc69394dc9412c7ac417c  bitcoin-0.18.99-win64-setup-unsigned.exe
 74aa2e0c4f32fcca6c557f2581aaf7578f271fe329264e090305d504223e62dcf  bitcoin-0.18.99-win64.zip
 8c7d72ac57753ffda64d88760d3e4c9bba1904faec342bf64150eb992dc9a003b  src/bitcoin-0.18.99.tar.gz
 9f3ba7af8c756a8cb87d71ffbde2b91654eda803d7fdcbd843ff910b85ce826bd  bitcoin-core-win-0.19-res.yml
10Done.
11
12real	51m3.421s
13user	0m10.100s
14sys	0m10.820s
  36. DrahtBot removed the label Needs gitian build on Sep 26, 2019
  37. MarcoFalke added the label Needs gitian build on Oct 9, 2019
  38. DrahtBot removed the label Needs gitian build on Oct 10, 2019
  39. theuni approved
  40. theuni commented at 3:07 pm on October 11, 2019: member

    ACK bd3f5a90ecd6de40516141b23b0861dbba0b31b6

    Edit: Maybe I ACKed too soon? Changes look good to me, I don’t see why this should affect the build in any weird way.

  41. MarcoFalke added the label Needs gitian build on Oct 11, 2019
  42. DrahtBot commented at 10:27 am on October 13, 2019: member

    Gitian builds for commit f4d93078dde502bb6a77dcc94ac6eafe20e36324 (master):

    Gitian builds for commit 9a78ea0345c19093bdea87c92d7c8af72718bcd9 (master and this pull):

  43. DrahtBot removed the label Needs gitian build on Oct 13, 2019
  44. MarcoFalke deleted a comment on Oct 13, 2019
  45. MarcoFalke deleted a comment on Oct 13, 2019
  46. MarcoFalke deleted a comment on Oct 13, 2019
  47. MarcoFalke added the label Needs gitian build on Oct 13, 2019
  48. laanwj approved
  49. laanwj commented at 9:40 am on October 14, 2019: member

    ACK bd3f5a90ecd6de40516141b23b0861dbba0b31b6

    Thanks for removing this horrible workaround. I do not understand how this change can cause random build issues, if anything, not setting a malloc-specific debug environment variable to clear all memory in advance should make the build more performant.

  50. DrahtBot commented at 9:56 am on October 14, 2019: member

    Gitian builds for commit 561a7d30478b82f5d46dcf0f16e864a9608004f4 (master):

    Gitian builds for commit 337095c3a790d01e4137df4772494e889426377f (master and this pull):

  51. DrahtBot removed the label Needs gitian build on Oct 14, 2019
  52. MarcoFalke commented at 12:38 pm on October 14, 2019: member

    I have no idea why this was failing to build locally and I haven’t debugged. DrahtBot seems to pass now (The bot had some hard drive issues in the past and I fixed them).

    3 ACKs and two successful builds by DrahtBot, going to merge now.

  53. MarcoFalke referenced this in commit 4765b91f50 on Oct 14, 2019
  54. MarcoFalke merged this on Oct 14, 2019
  55. MarcoFalke closed this on Oct 14, 2019
  56. fanquake deleted the branch on Oct 14, 2019
  57. sidhujag referenced this in commit a24510d22d on Oct 15, 2019
  58. hebasto referenced this in commit ad5ba57d5b on Mar 22, 2020
  59. hebasto referenced this in commit c8592ad24f on Mar 22, 2020
  60. hebasto referenced this in commit 8d0c980e64 on Apr 7, 2020
  61. MarkLTZ referenced this in commit 4fa36763ef on Apr 10, 2020
  62. hebasto referenced this in commit 19a51a8345 on Apr 11, 2020
  63. hebasto referenced this in commit 2aa48edec0 on Apr 17, 2020
  64. dongcarl referenced this in commit c98c828ec5 on Apr 22, 2020
  65. ariard referenced this in commit 0ca2a45efa on Apr 30, 2020
  66. pierreN referenced this in commit a2dec9b458 on May 1, 2020
  67. luke-jr referenced this in commit 8573d38263 on May 7, 2020
  68. luke-jr referenced this in commit b59cc80ff3 on May 7, 2020
  69. luke-jr referenced this in commit b84e35a910 on May 14, 2020
  70. random-zebra referenced this in commit 3614de632e on Jul 19, 2021
  71. furszy referenced this in commit 56200a9081 on Aug 23, 2021
  72. furszy referenced this in commit ca7a7f0282 on Aug 23, 2021
  73. furszy referenced this in commit ccd3c71bf9 on Sep 2, 2021
  74. UdjinM6 referenced this in commit 204e40f258 on Sep 9, 2021
  75. UdjinM6 referenced this in commit f507212049 on Sep 24, 2021
  76. UdjinM6 referenced this in commit 0edb4c5cd0 on Oct 4, 2021
  77. UdjinM6 referenced this in commit d7707cde7a on Oct 5, 2021
  78. kittywhiskers referenced this in commit 74339e429c on Oct 12, 2021
  79. pravblockc referenced this in commit dc74ad8893 on Nov 18, 2021
  80. Fabcien referenced this in commit 790efe069e on Dec 1, 2021
  81. MarcoFalke locked this on Dec 16, 2021


fanquake MarcoFalke theuni hebasto DrahtBot dongcarl laanwj

Labels
Build system

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 09:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me