Replace `-banscore` with `-ignoremisbehaviour` #16683

issue dongcarl opened this issue on August 22, 2019

dongcarl commented at 4:00 PM on August 22, 2019: member

While looking at #16682, @jnewbery noted to me in person that we should probably remove the banscore knob.

My thought is perhaps it could be replaced with a more useful debug flag like -ignoremisbehaviour.
jnewbery commented at 4:06 PM on August 22, 2019: member

concept ACK. -banscore seems to be not a very useful configuration option, especially since our own internal misbehaviour accounting can change between releases (eg #15141)
MarcoFalke added the label Brainstorming on Aug 22, 2019
MarcoFalke added the label P2P on Aug 22, 2019
fanquake commented at 1:18 AM on August 17, 2020: member

-banscore was removed in #19464.
MarcoFalke commented at 6:09 AM on August 17, 2020: member

Is there a use case to allow a wildcard ignoremisbehaviour for all peers? It might be better to have a per-peer flag(s) that can be toggled (similar or identical to net permissions) for known peers or peers controlled by the user themselves.
jnewbery commented at 8:12 AM on August 17, 2020: member

@MarcoFalke I can't think of a usecase for that. I think we should just close this issue now that banscore has been removed.
dongcarl closed this on Aug 17, 2020
DrahtBot locked this on Feb 15, 2022

Contributors

Labels