Prepare release notes for 0.19 #16690

pull harding wants to merge 3 commits into bitcoin:master from harding:2019-08-0.19-notes changing 19 files +255 −172
  1. harding commented at 12:03 AM on August 23, 2019: contributor

    Merges in detached release notes, edits each change down to a single paragraph bullet point (or, in a couple cases, two individual bullet points in separate sections each with a single paragraph). Adds notes for some undocumented changes I found reviewing git log --merges. Also tries something new: adds the PR number(s) after each entry to make it easier for both reviewers and end-user readers to look up the details behind each change. (If the PR numbers are unwanted, they're easy to remove either in this PR or later in the release process.)

    I also checked the 0.18 branch but I didn't find anything in the current release notes that had been backported.

    A particular focus in my editing was trying to keep things concise, particularly by pointing to RPC documentation when available (or upcoming, as in #16629). I do suspect that one downside of detached notes is that people write longer summaries than they would if they knew there were already 300 other lines of release notes. :-)

    The first commit only moves notes, puts them in bullet form, adjusts indentation appropriately, and drops unneeded headers. It can be reviewed with git diff --color-moved=dimmed-zebra for a little bit of a speedup, but unfortunately I wasn't smart enough to split my copy/pasting and line wrapping into separate commits, so it's not a transparently move-only change.

  2. Doc: move detached release notes into release-notes.md e7415a5a95
  3. fanquake added the label Docs on Aug 23, 2019
  4. fanquake added this to the milestone 0.19.0 on Aug 23, 2019
  5. DrahtBot commented at 12:51 AM on August 23, 2019: member

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #16539 (wallet: lower -txmaxfee default from 0.1 to 0.01 BTC by Sjors)
    • #16492 (rpc: Add feeRate argument to bumpFee RPC by ezegom)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  6. in doc/release-notes.md:71 in 6bc4c7578f outdated
      63 | @@ -64,61 +64,215 @@ platform.
      64 |  Notable changes
      65 |  ===============
      66 |  
      67 | +New user documentation
      68 | +----------------------
      69 | +
      70 | +- [Reduce memory](https://github.com/bitcoin/bitcoin/blob/master/doc/reduce-memory.md)
      71 | +  suggests configuration tweeks for running Bitcoin Core on systems with
    


    fanquake commented at 4:35 AM on August 23, 2019:

    s/tweeks/tweaks

  7. in doc/release-notes.md:225 in 6bc4c7578f outdated
     233 | +  This eliminates well-known DoS vectors in Bitcoin Core, especially for
     234 | +  nodes with spinning disks. Other software should still be able to
     235 | +  connect to older versions of Bitcoin Core and users who have manually
     236 | +  enabled NODE_BLOOM support for the near future, but developers of such
     237 | +  software should consider migrating to an alternative over the coming
     238 | +  years. (#16152)
    


    NicolasDorier commented at 4:37 AM on August 23, 2019:

    I think this is not good advise. BIP37, when connected to your own node, is the most efficient way to get a light wallet without the need of installing middlewares or the need of separate index incompatible with pruning.

    For this reason, whitebind and whitelist now support the bloomfilter permission, so whitelisted peer can still enjoy BIP37.


    harding commented at 5:19 AM on August 23, 2019:

    I'll add a mention of the bloomfilter permission (the ability to specify per-peer/network/interface options via white* is already mentioned in the document).

    That said, I'm skeptical of your argument. For privacy, BIP37 needs to be over a secure private link (e.g. authenticated and encrypted), and if you have that, you can just run the wallet RPCs for even higher efficiency than BIP37 with minimal false positives. Your pruning argument doesn't make sense to me (BIP37 needs full blocks, so it has problems with pruning that BIP158 doesn't---with BIP158, you can create the block filter and then throw away the full block and undo data); if you're thinking about Electrum-style indexes or Electrum Personal Server rescanning, BIP37 seems equivalent in problems related to pruning). This is probably off-topic for release notes discussion, though, so DM me on IRC or poke me in #bitcoin if you're bored and want to debate it. :-)


    NicolasDorier commented at 9:09 AM on August 23, 2019:

    DMed on twitter :)

  8. in doc/release-notes.md:169 in 6bc4c7578f outdated
     174 | +  progress of the wallet's scanning historical blocks for transactions
     175 | +  affecting its balances. (#15730)
     176 | +
     177 | +- `createwallet` accepts a new `passphrase` parameter.  If set, this
     178 | +  will create the new wallet encrypted with the given passphrase.  If
     179 | +  unset or empty (the default), a warning will be printed and no
    


    fanquake commented at 4:49 AM on August 23, 2019:

    a warning will be printed

    I only see a warning calling src/bitcoin-cli createwallet "test" false false "" false (i.e empty passphrase). Not in the src/bitcoin-cli createwallet "test" (unset?) case.

  9. fanquake commented at 6:31 AM on August 23, 2019: member

    Thanks for following up with this, looks pretty good. I've been through and checked PR numbers, links, RPC behavior changes etc. Left a few comments inline.

  10. Release notes: edit previously-detached notes 7e1634a927
  11. Release notes: add previously undocumented changes 74e3876989
  12. in doc/release-notes.md:80 in 6bc4c7578f outdated
      77 |  - `getbalances` returns an object with all balances (`mine`,
      78 |    `untrusted_pending` and `immature`). Please refer to the RPC help of
      79 |    `getbalances` for details. The new RPC is intended to replace
      80 | -  `getunconfirmedbalance` and the balance fields in `getwalletinfo`, as well as
      81 | -  `getbalance`. The old calls may be removed in a future version.
      82 | +  `getbalance`, `getunconfirmedbalance`, and the balance fields in
    


    hebasto commented at 7:02 AM on August 23, 2019:

    Is the second comma redundant?


    harding commented at 7:09 PM on August 23, 2019:

    Among writers, whether or not to always use the serial comma is our version of vi versus emacs. Here's the first search result for the issue, which seems reasonably descriptive and even-handed. I fall into the camp of people who always use the serial comma, but I willing to do lazy commas if necessary with only a few sotto voce grumblings as if you had also asked me to work in emacs. :-)

  13. harding force-pushed on Aug 23, 2019
  14. harding commented at 7:17 PM on August 23, 2019: contributor

    Forced pushed with updates for the provided feedback. Thanks for the reviews @NicolasDorier, @fanquake, and @hebasto!

  15. in doc/release-notes-16383.md:4 in 74e3876989
       0 | @@ -1,8 +0,0 @@
       1 | -RPC changes
       2 | ------------
       3 | -
       4 | -RPCs which have an `include_watchonly` argument or `includeWatching`
    


    meshcollider commented at 2:05 AM on August 24, 2019:

    Looks like this detached release note was lost?


    MarcoFalke commented at 5:44 PM on August 26, 2019:

    Jup, this is missing now.


    jb55 commented at 12:29 AM on September 28, 2019:

    this was never fixed right? I don't see it :(

  16. fanquake approved
  17. fanquake commented at 2:09 AM on August 24, 2019: member

    ACK 74e38769895c643d75f77634519c1442fa38bad6 - Thanks for doing this. It's nice to have a gauge of what's going to be in the 0.19.0 release.

  18. in doc/release-notes.md:125 in 7e1634a927 outdated
     127 | -  filled in from the UTXO set when a descriptor is provided that shows
     128 | -  they're spending segwit outputs.
     129 | -
     130 | -  See the RPC help text for full details.
     131 | -
     132 | -- The -maxtxfee setting no longer has any effect on non-wallet RPCs.
    


    meshcollider commented at 2:20 AM on August 24, 2019:

    note: this was also dropped (seems ok though)


    harding commented at 2:46 AM on August 24, 2019:

    This was just substantially rewritten. Original was:

    - The -maxtxfee setting no longer has any effect on non-wallet RPCs.
    
      The `sendrawtransaction` and `testmempoolaccept` RPC methods previously
      accepted an `allowhighfees` parameter to fail the mempool acceptance in case
      the transaction's fee would exceed the value of the command line argument
      `-maxtxfee`. To uncouple the RPCs from the global option, they now have a
      hardcoded default for the maximum transaction fee, that can be changed for
      both RPCs on a per-call basis with the `maxfeerate` parameter. The
      `allowhighfees` boolean option has been removed and replaced by the
      `maxfeerate` numeric option.
    

    Revised is:

    - `sendrawtransaction` and `testmempoolaccept` no longer accept a
      `allowhighfees` parameter to fail mempool acceptance if the
      transaction fee exceedes the value of the configuration option
      `-maxtxfee`.  Now there is a hardcoded default maximum feerate that
      can be changed when calling either RPC using a `maxfeerate` parameter.
      (#15620)
    

    The other note you identified as lost does seem to be so. I'll create a followup PR for that and the formatting change. Thanks!

  19. in doc/release-notes.md:106 in 74e3876989
     103 | +  (#14121)
     104 | +
     105 | +Updated settings
     106 | +----------------
     107 | +
     108 | +- `whitebind` and `whitelist` now accept a list of permissions to
    


    meshcollider commented at 2:29 AM on August 24, 2019:

    -whitebind and -whitelist

  20. meshcollider commented at 2:36 AM on August 24, 2019: contributor

    Overall looks great, thanks @harding !

    ACK 74e38769895c643d75f77634519c1442fa38bad6

    Just a couple of small comments that can be done in followups if needed (since this file will still undergo modifications right up until release)

  21. meshcollider referenced this in commit 910ff94cf5 on Aug 24, 2019
  22. meshcollider merged this on Aug 24, 2019
  23. meshcollider closed this on Aug 24, 2019

  24. sidhujag referenced this in commit 2eb0fa935a on Aug 25, 2019
  25. in doc/release-notes.md:276 in 74e3876989
     294 | -- An error is issued where previously a warning was issued when a setting in
     295 | -  the config file was specified in the default section, but not overridden for
     296 | -  the selected network. This change takes only effect if the selected network
     297 | -  is not mainnet.
     298 | +- A setting specified in the default section but not also specified in a
     299 | +  network-specific section (e.g. testnet) will now produce a error
    


    MarcoFalke commented at 5:51 PM on August 26, 2019:
    s/a error/an error/
    

    ?

  26. in doc/release-notes.md:181 in 74e3876989
     186 | +  containing the checksum for the unmodified descriptor provided by the
     187 | +  user (that is, before the descriptor is normalized for the
     188 | +  `descriptor` field). (#15986)
     189 | +
     190 | +- `walletcreatefundedpsbt` now signals BIP125 Replace-by-Fee if the
     191 | +  `-walletrbf` configuration option is set to true. (#15911)
    


    MarcoFalke commented at 5:58 PM on August 26, 2019:

    This will be release in 0.18.2, so I'd rather mention it in those release notes.

  27. MarcoFalke commented at 6:00 PM on August 26, 2019: member

    ACK

  28. DrahtBot locked this on Dec 16, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 18:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me