Updating rpcauth and extract_strings_qt following style guidelines (PEP-8) #16715

pull brunoerg wants to merge 2 commits into bitcoin:master from brunoerg:master changing 2 files +28 −11

brunoerg commented at 8:39 PM on August 24, 2019: member

Updating rpcauth.py and extract_strings_qt.py following the proposed style guidelines shown in /test/functional/README.md#style-guidelines.
fix pep8 2a239e2564
fix 75c93fcab5
DrahtBot commented at 9:56 PM on August 24, 2019: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #16539 (wallet: lower -txmaxfee default from 0.1 to 0.01 BTC by Sjors)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
fanquake added the label Scripts and tools on Aug 24, 2019
promag commented at 11:35 PM on August 24, 2019: member

-0 on this, just because its almost only style changes. Anyway please squash and give a better commit message like qa: Format extract_strings_qt.py and rpcauth.py with pep8 or something like that.
fanquake commented at 4:33 AM on August 25, 2019: member

Thanks. However given this is just styling changes, and isn't mergable as is (multiple commits, no proper commit message etc), I'm going to close. Checkout the good first issue list if you're interested in contributing.
fanquake closed this on Aug 25, 2019
DrahtBot locked this on Dec 16, 2021

Contributors

Labels