The resource on the Boost unit test framework previously linked to in src/test/README.md was a stale URL.
~Instead of deleting it, I've replaced it with an alternative resource on the framework on boost.org.~
doc: Delete stale URL in test README #16752
pull michaelfolkson wants to merge 1 commits into bitcoin:master from michaelfolkson:20190829-boost-url changing 1 files +0 −4-
michaelfolkson commented at 9:24 AM on August 29, 2019: contributor
- fanquake added the label Docs on Aug 29, 2019
-
laanwj commented at 9:34 AM on August 29, 2019: member
Good catch. I'd slightly favor removing this completely, to adding another link (to a specific boost version) that might go stale as well.
-
michaelfolkson commented at 9:36 AM on August 29, 2019: contributor
Makes sense. Probably want to avoid URLs completely in all the docs?
-
jonatack commented at 9:58 AM on August 29, 2019: member
ACK 7e5d4b3e004b0ace8abb5a024aee72ca67f568ee modulo squash
-
laanwj commented at 10:03 AM on August 29, 2019: member
ACK after squash, this should be one commit (see https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits ).
Makes sense. Probably want to avoid URLs completely in all the docs?
I don't think we'd want to be that drastic. Links can be very useful, especially if it explains something non-trivial. But this specific case is simply a link to a random blog post about boost test, nothing a search query can't address.
- michaelfolkson force-pushed on Aug 29, 2019
-
doc: Delete stale URL in test README 41d484d5c8
- michaelfolkson force-pushed on Aug 29, 2019
- michaelfolkson renamed this:
doc: Replace stale URL in test README with alternative Boost resource
doc: Replace stale URL in test README
on Aug 29, 2019 -
hebasto commented at 11:08 AM on August 29, 2019: member
@michaelfolkson
The latest commit 41d484d5c88f057e75cfdd8b88587b9a12a61744 seems a bit wrong. Could you verify?Ah, delete instead of replace.
- fanquake renamed this:
doc: Replace stale URL in test README
doc: Delete stale URL in test README
on Aug 29, 2019 -
promag commented at 11:14 AM on August 29, 2019: member
ACK 41d484d5c88f057e75cfdd8b88587b9a12a61744.
I'm sure anyone can find good documentation.
-
hebasto commented at 11:16 AM on August 29, 2019: member
ACK 41d484d5c88f057e75cfdd8b88587b9a12a61744, the removed link is really obsolete.
- fanquake approved
-
fanquake commented at 11:17 AM on August 29, 2019: member
ACK 41d484d5c88f057e75cfdd8b88587b9a12a61744 - Thanks.
- fanquake referenced this in commit b7ff38972c on Aug 29, 2019
- fanquake merged this on Aug 29, 2019
- fanquake closed this on Aug 29, 2019
- michaelfolkson deleted the branch on Sep 1, 2019
- PastaPastaPasta referenced this in commit 9d3122b03e on Jun 27, 2021
- PastaPastaPasta referenced this in commit f833cf997b on Jun 28, 2021
- PastaPastaPasta referenced this in commit 3a8fe9d459 on Jun 29, 2021
- PastaPastaPasta referenced this in commit 64b02d5c2a on Jul 1, 2021
- PastaPastaPasta referenced this in commit f0db68954f on Jul 1, 2021
- PastaPastaPasta referenced this in commit 205c744620 on Jul 12, 2021
- PastaPastaPasta referenced this in commit 33aa4c2840 on Jul 13, 2021
- DrahtBot locked this on Dec 16, 2021
