Comes with a test to aid review. The test should fail without the fix to bitcoind
The following CreateWalletFromFile issues are fixed:
walletFile refers to freed memory and will thus corrupt the debug.log and/or crash the node if readWalletParameterInteraction was moved to CreateWalletFromFile and WalletInit::ParameterInteraction without updating the documentation
ACK fa734603b78ba31ebf0da5d2dbe87386eafff01a.
fab3c34412379598b812631e3c123e9467cdc485 is a nice addition.
28@@ -27,6 +29,13 @@ def set_test_params(self):
29 def skip_test_if_missing_module(self):
30 self.skip_if_no_wallet()
31
32+ def add_options(self, parser):
33+ parser.add_argument(
34+ '--data_wallets_dir',
35+ default=os.path.join(os.path.dirname(os.path.realpath(__file__)), 'data/wallets/'),
36+ help='Test data with wallet directories (default: %(default)s)',
% locals() at the end to fill the %(default)s?
This is done by the argparse module. It can be tested with
0$ ./test/functional/wallet_multiwallet.py --help|tail -4
1 --data_wallets_dir DATA_WALLETS_DIR
2 Test data with wallet directories (default: /home/marc
3 o/workspace/btc_bitcoin_core/test/functional/data/wall
4 ets/)
test/functional/data/wallets/high_minversion/wallet.dat
I think if we’re going to add binary test blobs like this, they should be accompanied with comments saying how they are generated and intended to be maintained. For example, this information could go in accompanying README.md or generate.sh files.
Without this information, as code is updated in the future, and especially if more binary blobs are added, we’re going to be faced with unpleasant choices of:
Better to just record upfront what’s in the blobs and how they should be treated. Would be nice to have a followup PR adding this.