Refactor rawtransaction_util’s SignTransaction to separate prevtx parsing #16798

1. 
   achow101 commented at 7:53 pm on September 3, 2019: member

   Currently the SignTransaction function has to handle both the actual signing and parsing of previous transaction data. This PR splits it so that SignTransaction only handles the signing itself and adds a ParsePrevouts function which handles parsing the prevtx information.

   This allows for SignTransaction to just take any SigningProvider.

   Split from #16341

2. Refactor rawtransaction_util's SignTransaction to have previous tx parsing be separate 39034f1ee6
3. fanquake added the label RPC/REST/ZMQ on Sep 3, 2019
4. 
   DrahtBot commented at 9:03 pm on September 3, 2019: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #16546 ([WIP] External signer support - Wallet Box edition by Sjors)
   • #16528 ([WIP] Native Descriptor Wallets (take 2) by achow101)
   • #16341 (Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101)
   • #16251 (Improve signrawtransaction error reporting by ajtowns)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

5. ryanofsky approved
6. 
   ryanofsky commented at 3:10 pm on September 4, 2019: member

   utACK 39034f1ee628dae0bc9da5b1b30b8a424e66d968. No change since previously reviewed b49bbb939be92a67ff77c3f7bca5bb94dd141906, #16341#pullrequestreview-278610269 other than rebase with no conflicts.
7. MarcoFalke added the label Refactoring on Sep 5, 2019
8. 
   MarcoFalke commented at 0:09 am on September 5, 2019: member

   ACK 39034f1ee628dae0bc9da5b1b30b8a424e66d968

   Signature:

    0-----BEGIN PGP SIGNED MESSAGE-----
    1Hash: SHA512
    2
    3ACK 39034f1ee628dae0bc9da5b1b30b8a424e66d968
    4-----BEGIN PGP SIGNATURE-----
    5
    6iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
    7pUheggv/VvRRJmPs89YAyGpMgoCCftMBKXJy/XIrP53n34mtGI9sOoOSgvw4S2ZO
    8gHH3Qo16z7CdZZsj8p8fg0E/DlGLrDWeIOnNhh5gt2rL4aQvoDauki2QjdWDSaxm
    9IKGkLQJT7MdRre3unrVr65Whe5LiMnUFKcqINHtJ+WWD6PnDfzFpK6E6ucRkUlZQ
   10GnfY9WLQP3Nh8UfHi7e9azY1+HMkhUGttNILChDCtOXwks52yScqfAa8kZPfYgsj
   112/k+rLQ8XRRAP0GNZYuarlpwziUqc3W2a+0XOQjvkhdptwXP0ikSDvb1geg+nyOQ
   12E/aFmJpBOoDwshj5JmB7QP605WrGAOe6dONXv0IxsdPQa3NkYYLZdVporZYeGG12
   13FEaXQCgI7CeTRKl3STdics/I3pDPjDZTuAlnqakd06z+swWFnMOR3AtiymPok9QU
   14yvvrIkvyqfFXMibuKJaPeOrJjREkvtBqXN/f6SVNvEuGPoWnS8oYzo+1wHGuwiMy
   15HyH6cXfK
   16=7nCA
   17-----END PGP SIGNATURE-----
   

   Timestamp of file with hash b4b83c42ea3e2775714fcbbe1b251994d411eab089a19d75efa9a30780ff0eb9 -

9. 
   instagibbs commented at 7:44 pm on September 6, 2019: member

   utACK https://github.com/bitcoin/bitcoin/pull/16798/commits/39034f1ee628dae0bc9da5b1b30b8a424e66d968
10. fanquake referenced this in commit 46494b08e2 on Sep 7, 2019
11. fanquake merged this on Sep 7, 2019
12. fanquake closed this on Sep 7, 2019

    ---

13. sidhujag referenced this in commit 9282d8beb9 on Sep 10, 2019
14. jasonbcox referenced this in commit f2d57b2aa7 on Aug 5, 2020
15. jasonbcox referenced this in commit 96c54d32f2 on Oct 22, 2020
16. DrahtBot locked this on Dec 16, 2021

Contributors
achow101 DrahtBot ryanofsky MarcoFalke instagibbs

Labels
Refactoring RPC/REST/ZMQ