Recent update to boost m4 lost error reporting improvements #16803

issue laanwj opened this issue on September 4, 2019

laanwj commented at 8:51 AM on September 4, 2019: member

Back in 2014 I made some error reporting changes in 25333a26197b55c23debb38740ed875999aa795a (#3986), to do with reporting the exact boost library that was not being found. These were recently (unintentionally, I assume) removed in aa85dcf47288e86f283f38fe47c022ffcfa53d8b (#13095) by @fanquake.

I'm not sure how much of a problem this is, but wanted to create an issue nevertheless because these this error still gets reported all the time and for troubleshooting it was useful: #3219 (comment) .

If people feel this is worth it it'd be trivial to re-do the change.
laanwj added the label Build system on Sep 4, 2019
MarcoFalke added the label Upstream on Sep 4, 2019
fanquake assigned fanquake on Sep 6, 2019
fanquake commented at 10:02 AM on September 13, 2019: member

I've opened a PR upstream to improve the error reporting of all the Boost macros, and will pull the changes into our repository once they it has been merged.
fanquake referenced this in commit bb99c4e684 on Sep 13, 2019
fanquake closed this on Sep 21, 2019
fanquake referenced this in commit cf57e33cc6 on Sep 21, 2019
fanquake referenced this in commit 4e3f39434d on Sep 21, 2019
laanwj commented at 5:05 PM on September 21, 2019: member

Thank you @fanquake
sidhujag referenced this in commit 1b5b19e8c6 on Sep 23, 2019
fanquake referenced this in commit 45fb3f81bc on Sep 23, 2019
fanquake referenced this in commit 3b8af5f383 on Oct 1, 2019
PierreRochard referenced this in commit cd25cc2f65 on Oct 12, 2019
HashUnlimited referenced this in commit f6320d6bc3 on Nov 17, 2019
deadalnix referenced this in commit 53a3ec1060 on Apr 1, 2020
ftrader referenced this in commit def73e3596 on Aug 17, 2020
michelvankessel referenced this in commit baa664eaff on Sep 19, 2020
PastaPastaPasta referenced this in commit b84611ce4e on Jun 27, 2021
PastaPastaPasta referenced this in commit 7f483f18fa on Jun 28, 2021
PastaPastaPasta referenced this in commit 527428eeed on Jun 29, 2021
PastaPastaPasta referenced this in commit 98b29c9bcf on Jul 1, 2021
PastaPastaPasta referenced this in commit 2b6752b616 on Jul 1, 2021
PastaPastaPasta referenced this in commit cdff73db26 on Jul 12, 2021
PastaPastaPasta referenced this in commit d3a9042e01 on Jul 13, 2021
MarcoFalke locked this on Dec 16, 2021
lyricidal referenced this in commit 513ea50dae on Mar 23, 2023

Contributors

laanwj

fanquake

Labels

Build system Upstream

Linked (view graph)

#3219 Default boost 1.53 on Ubuntu 13.10 doesn't work #3986 Small build and doc improvements #13095 build: update ax_boost_chrono/unit_test_framework #16870 build: update boost macros to latest upstream for improved error reporting