rpc: Fix casing in getblockchaininfo to be inline with other fields #16817

1. 
   dangershony commented at 11:34 AM on September 6, 2019: contributor

   The response in the RPC result startTime is camel cased while the rest of the response seems to be lower cased.

   If this was intentional please ignore and close this PR.

   Note: RPC field case changes might break existing callers

2. fanquake added the label RPC/REST/ZMQ on Sep 6, 2019
3. 
   promag commented at 11:45 AM on September 6, 2019: member

   Note: RPC field case changes might break existing callers

   Right, NACK for that reason.

4. 
   MarcoFalke commented at 11:49 AM on September 6, 2019: member

   The interface was broken in this release anyway. So might as well fix it up. I have no opinion on which one should be preferred.

5. fanquake renamed this:
   [RPC] Fix casing in getblockchaininfo to be inline other fields
   rpc: Fix casing in getblockchaininfo to be inline with other fields
   on Sep 6, 2019
6. 
   promag commented at 11:54 AM on September 6, 2019: member

   @MarcoFalke oh ok.

7. 
   fanquake commented at 2:12 PM on September 8, 2019: member

   I think starttime is ok. @dangershony can you please squash your commits.

8. dangershony force-pushed on Sep 9, 2019
9. 
   fanquake commented at 8:24 AM on September 16, 2019: member

   ACK f057b5f4479f00d0947eade2cd5bbb1acce49ded

10. fanquake added this to the milestone 0.19.0 on Sep 24, 2019
11. 
    laanwj commented at 2:13 PM on September 25, 2019: member

    from the RPC interface guidelines:

    • Argument naming: use snake case fee_delta (and not, e.g. camel case feeDelta)

    ACK (well it's not snake case, start_time would be even better maybe, but anyhow we shouldn't use camel case in RPC fields)

12. 
    MarcoFalke commented at 5:19 PM on September 25, 2019: member

    ACK f057b5f4479f00d0947eade2cd5bbb1acce49ded (I am fine with start_time as well)

13. 
    promag commented at 5:30 PM on September 25, 2019: member

    ACK either but prefer start_time (2 words, snake case, no way to get it wrong)

14. MarcoFalke added the label Waiting for author on Sep 25, 2019
15. 
    MarcoFalke commented at 5:33 PM on September 25, 2019: member

    Ok, added "waiting for author" label @dangershony ^

16. MarcoFalke added the label Up for grabs on Sep 26, 2019
17. 
    dangershony commented at 1:44 PM on September 26, 2019: contributor

    I will make the changes hang on.

18. MarcoFalke removed the label Up for grabs on Sep 26, 2019
19. [RPC] Fix casing in getblockchaininfo to be inline with the rest of the response

    The response in the RPC result `starttime` is camel cased while the rest of the response seems to be lower cased.
    
    If this was intentional please ignore this PR.
    
    Note: case might break existing callers
    
    Reflect the change in the test data
    
    Change to snake case

    1a02edb3f2
20. dangershony force-pushed on Sep 26, 2019
21. fanquake removed the label Waiting for author on Sep 27, 2019
22. 
    laanwj commented at 1:10 PM on September 27, 2019: member

    ACK 1a02edb3f2803b6f82f06a31acf0b0e5fc19bd1c

23. laanwj referenced this in commit a6c8aed1f1 on Sep 27, 2019
24. laanwj merged this on Sep 27, 2019
25. laanwj closed this on Sep 27, 2019

    ---

26. dangershony deleted the branch on Oct 7, 2019
27. jasonbcox referenced this in commit 761a612777 on Oct 23, 2020
28. Munkybooty referenced this in commit 52d2004b0b on Dec 9, 2021
29. DrahtBot locked this on Dec 16, 2021

Contributors

dangershonypromagMarcoFalkefanquakelaanwj

Milestone
0.19.0