doc: Update CONTRIBUTING.md #16818

pull RajaMBZ wants to merge 2 commits into bitcoin:master from RajaMBZ:patch-1 changing 1 files +5 −5

RajaMBZ commented at 11:47 PM on September 6, 2019: none

-Addition of (much-needed) commas.

doc: Update CONTRIBUTING.md

-Addition of (much-needed) commas.
-Correction of a grammatical error.

eb417840c5

fanquake added the label Docs on Sep 6, 2019
Update CONTRIBUTING.md cc2ab45e47

in CONTRIBUTING.md:25 in eb417840c5 outdated

  21 | @@ -22,7 +22,7 @@ Communication Channels
  22 |  ----------------------
  23 |  
  24 |  Most communication about Bitcoin Core development happens on IRC, in the
  25 | -#bitcoin-core-dev channel on Freenode. The easiest way to participate on IRC is
  26 | +#bitcoin-core-dev channel on Freenode. The easiest way to participate in IRC is

sipa commented at 11:53 PM on September 6, 2019:

This is incorrect.

RajaMBZ commented at 12:01 AM on September 7, 2019:

Reverted back that particular change in the 2nd commit.

fanquake commented at 12:15 AM on September 7, 2019: member

Please squash your commits.
sipsorcery commented at 10:13 AM on September 7, 2019: member

NACK use of commas is very subjective (particularly before "and" on lists) and IMHO these additions don't improve readability. @RajaMBZ effort appreciated though and not meant to discourage. Just adding my 2c.
michaelfolkson commented at 11:12 AM on September 7, 2019: contributor

NACK also. I don't agree with the use of at least one of these commas.

More importantly I don't think this is a priority for some of the participants in this thread. @RajaMBZ: As a new contributor I'm happy to discuss ideas with you on how to contribute to the docs if you're interested in doing so going forward. For now I recommend closing this particular PR.
RajaMBZ commented at 12:19 PM on September 7, 2019: none

Well, thank you all for providing your valuable feedback & suggestion(s) in this regard. I'm now closing this PR.
RajaMBZ closed this on Sep 7, 2019
DrahtBot locked this on Dec 16, 2021

Contributors

Labels