wallet: Rename 'decode' argument in gettransaction method to 'verbose' #16866

1. 
   jnewbery commented at 7:35 PM on September 13, 2019: member

   This makes the RPC method consistent with other RPC methods that have a 'verbose' option.

   Change the name of the return object from 'decoded' to details.

   Update help text.

2. [wallet] Rename 'decode' argument in gettransaction method to 'verbose'

   This makes the RPC method consistent with other RPC methods that have a
   'verbose' option.
   
   Change the name of the return object from 'decoded' to details.
   
   Update help text.

   7dee8f4808
3. 
   jnewbery commented at 7:36 PM on September 13, 2019: member

   Suggested here: #16185 (comment) @ryanofsky @promag

   Also addresses @MarcoFalke's comment here: #16185 (review)

4. jnewbery added this to the milestone 0.19.0 on Sep 13, 2019
5. fanquake added the label RPC/REST/ZMQ on Sep 13, 2019
6. fanquake added the label Wallet on Sep 13, 2019
7. 
   jnewbery commented at 7:37 PM on September 13, 2019: member

   I'm assigning this to 0.19 to avoid an API change for the new argument.

8. 
   jonatack commented at 7:42 PM on September 13, 2019: member

   Concept ACK. Will review over this weekend.

9. 
   DrahtBot commented at 8:27 PM on September 13, 2019: member

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--174a7506f384e20aa4161008e828411d-->

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #16365 (Log RPC parameters (arguments) if -debug=rpcparams by LarryRuane)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

10. meshcollider approved
11. 
    meshcollider commented at 8:01 AM on September 14, 2019: contributor

    Code review ACK 7dee8f48088c75ab0e51be60679505f8ce570919

12. 
    promag commented at 9:25 AM on September 14, 2019: member

    ACK 7dee8f48088c75ab0e51be60679505f8ce570919.

13. fanquake renamed this:
    [wallet] Rename 'decode' argument in gettransaction method to 'verbose'
    wallet: Rename 'decode' argument in gettransaction method to 'verbose'
    on Sep 14, 2019
14. NeedsAdjustment approved
15. 
    NeedsAdjustment commented at 9:37 AM on September 14, 2019: none

    I rate these changes 5/5 stars. Keep up the good work developers!

16. 
    0xB10C commented at 9:38 AM on September 14, 2019: member

    ACK 7dee8f48088c75ab0e51be60679505f8ce570919: reviewed code

17. meshcollider referenced this in commit 4bfef0daeb on Sep 14, 2019
18. meshcollider merged this on Sep 14, 2019
19. meshcollider closed this on Sep 14, 2019

    ---

20. 
    jonatack commented at 11:29 AM on September 14, 2019: member

    The possible issue here is that the new details section overloads and replaces the pre-existing details in the response, whereas before the decoded section did not remove the details. Seems like a breaking API change unless I'm misunderstanding the intention of this PR.

    Will propose a change to address this.

21. jnewbery deleted the branch on Sep 14, 2019
22. 
    jnewbery commented at 11:09 PM on September 14, 2019: member

    the new details section overloads and replaces the pre-existing details

    oops. Good catch @jonatack ! That was a clumsy mistake.

23. meshcollider referenced this in commit b0a7a76c9d on Sep 15, 2019
24. luke-jr referenced this in commit 46c624ef07 on Sep 21, 2019
25. vansergen referenced this in commit 21ab707301 on Mar 26, 2020
26. jasonbcox referenced this in commit 567961d857 on Sep 7, 2020
27. DrahtBot locked this on Dec 16, 2021

Contributors

jnewberyjonatackDrahtBotmeshcolliderpromagNeedsAdjustment0xB10C

Milestone
0.19.0