build: make building protobuf optional in depends #16871

pull fanquake wants to merge 2 commits into bitcoin:master from fanquake:depends_no_protobuf_by_default changing 7 files +18 −6
  1. fanquake commented at 3:13 AM on September 14, 2019: member

    As mentioned by dongcarl in #15584 (comment), make building protobuf optional in depends. With this change it will only be built if you pass PROTOBUF=1.

  2. doc: clarify protobuf build requirements ff6122f32b
  3. fanquake added the label Build system on Sep 14, 2019
  4. fanquake added this to the milestone 0.19.0 on Sep 14, 2019
  5. fanquake requested review from dongcarl on Sep 14, 2019
  6. DrahtBot commented at 3:20 AM on September 14, 2019: member

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #16367 (Multiprocess build support by ryanofsky)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  7. fanquake force-pushed on Sep 14, 2019
  8. build: make protobuf optional in depends
    Those that want to build it can now pass PROTOBUF=1.
    107e030723
  9. fanquake force-pushed on Sep 14, 2019
  10. laanwj commented at 7:47 AM on September 14, 2019: member

    code review ACK 107e030723552cf272dc8da01bb682032a457a3d

  11. MarcoFalke added the label Needs gitian build on Sep 14, 2019
  12. DrahtBot commented at 4:00 PM on September 15, 2019: member

    <!--a722867cd34abeea1fadc8d60700f111-->

    Gitian builds for commit 4bfef0daeb9351c200b5bd09e60596a29b4d3523 (master):

    Gitian builds for commit 86e97fc5bdc1b207df9189882acce199496e70a9 (master and this pull):

  13. DrahtBot removed the label Needs gitian build on Sep 15, 2019
  14. Sjors commented at 10:15 AM on September 16, 2019: member

    tACK 107e030 on macOS 10.14. When I build depends with PROTOBUF=1 then ./configure has bip70 enabled.

  15. laanwj referenced this in commit 19f301def7 on Sep 16, 2019
  16. laanwj merged this on Sep 16, 2019
  17. laanwj closed this on Sep 16, 2019
  18. sidhujag referenced this in commit 45053ec42a on Sep 16, 2019
  19. fanquake deleted the branch on Oct 12, 2019
  20. deadalnix referenced this in commit f1bf355981 on Apr 2, 2020
  21. ftrader referenced this in commit 7e281c57e2 on Aug 17, 2020
  22. Munkybooty referenced this in commit a617230df4 on Dec 7, 2021
  23. Munkybooty referenced this in commit 70e8603397 on Dec 15, 2021
  24. Munkybooty referenced this in commit 1d183776cb on Dec 15, 2021
  25. MarcoFalke locked this on Dec 16, 2021
Contributors
fanquakeDrahtBotlaanwjSjors


dongcarl

Labels
Build system

Milestone
0.19.0

Linked (view graph)
#15584 build: disable BIP70 support by default
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 06:14 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me